Attempt to fix clang build another time.

Attempt to fix clang build another time.

This error is not reproducible with my local clang build.

Committed: https://code.google.com/p/dart/source/detail?r=43106

[Florian Schneider, 2015-01-23 13:46:18]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[Florian Schneider, 2015-01-23 13:46:37]

TBR

[Florian Schneider, 2015-01-23 13:47:45]

Committed patchset #1 (id:1) manually as r43106 (presubmit successful).

[Vyacheslav Egorov (Google), 2015-01-23 13:48:53]

lgtm

[Ivan Posva, 2015-01-23 18:57:31]

iposva@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2015-01-23 18:57:31]

Please fix at least the use of defines.

-Ivan

https://codereview.chromium.org/867223003/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/867223003/diff/1/runtime/vm/raw_object.h#newc...
runtime/vm/raw_object.h:1026: #if defined(TARGET_ARCH_X64) ||
defined(TARGET_ARCH_ARM64)
ARCH_IS_64_BIT

Alternatively you could limit the offset to a reasonable amount and have some
bits left over with the added benefit that you can go back to Utils::IsUint(24,
value).

[Florian Schneider, 2015-01-26 10:28:02]

https://codereview.chromium.org/867223003/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://codereview.chromium.org/867223003/diff/1/runtime/vm/raw_object.h#newc...
runtime/vm/raw_object.h:1026: #if defined(TARGET_ARCH_X64) ||
defined(TARGET_ARCH_ARM64)
On 2015/01/23 18:57:31, Ivan Posva wrote:
> ARCH_IS_64_BIT
> 
> Alternatively you could limit the offset to a reasonable amount and have some
> bits left over with the added benefit that you can go back to
Utils::IsUint(24,
> value).

The proper fix would be to rewrite IsUint/IsInt to work on cross-platform.
Unfortunately I can't reproduce the buildbot's error messages: My previous
asserts all compiled fine locally with clang and gcc), so doing this would
involve guesswork about what may compile there.