Attempt to fix clang build another time.

runtime/vm/raw_object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_RAW_OBJECT_H_
 #define VM_RAW_OBJECT_H_
 
 #include "platform/assert.h"
 #include "vm/atomic.h"
 #include "vm/globals.h"
@@ skipping 1005 matching lines @@
     kRuntimeCall     = kClosureCall << 1,  // Runtime call.
     kOsrEntry        = kRuntimeCall << 1,  // OSR entry point in unopt. code.
     kOther           = kOsrEntry << 1,
     kAnyKind         = 0xFF
   };
 
   // Compressed version assumes try_index is always -1 and does not store it.
   struct PcDescriptorRec {
     uword pc_offset() const { return pc_offset_; }
     void set_pc_offset(uword value) {
-      ASSERT((sizeof(value) == 4) ||
-             static_cast<uint64_t>(value) <= static_cast<uint64_t>(kMaxUint32));
+#if defined(TARGET_ARCH_X64) || defined(TARGET_ARCH_ARM64)

[Ivan Posva, 2015/01/23 18:57:31]

ARCH_IS_64_BIT

Alternatively you could limit the offset to a reasonable amount and have some
bits left over with the added benefit that you can go back to Utils::IsUint(24,
value).

[Florian Schneider, 2015/01/26 10:28:01]

The proper fix would be to rewrite IsUint/IsInt to work on cross-platform.
Unfortunately I can't reproduce the buildbot's error messages: My previous
asserts all compiled fine locally with clang and gcc), so doing this would
involve guesswork about what may compile there.

+      ASSERT(value <= static_cast<uword>(kMaxUint32));
+#endif
       pc_offset_ = value;
     }
 
     Kind kind() const {
       return static_cast<Kind>(deopt_id_and_kind_ & kAnyKind);
     }
     void set_kind(Kind kind) {
       deopt_id_and_kind_ = (deopt_id_and_kind_ & 0xFFFFFF00) | kind;
     }
 
@@ skipping 1119 matching lines @@
   COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid ==
                  kTypedDataInt8ArrayViewCid + 15);
   COMPILE_ASSERT(kByteBufferCid == kExternalTypedDataInt8ArrayCid + 14);
   COMPILE_ASSERT(kNullCid == kByteBufferCid + 1);
   return (kNullCid - kTypedDataInt8ArrayCid);
 }
 
 }  // namespace dart
 
 #endif  // VM_RAW_OBJECT_H_