Split profiler.cc into profiler.cc and profiler_service.cc

Split profiler.cc into profiler.cc and profiler_service.cc

BUG=
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43623

[Cutch, 2015-02-09 22:37:53]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-02-09 23:20:00]

lgtm

https://codereview.chromium.org/864173008/diff/1/runtime/vm/scope_timer.h
File runtime/vm/scope_timer.h (right):

https://codereview.chromium.org/864173008/diff/1/runtime/vm/scope_timer.h#new...
runtime/vm/scope_timer.h:13: explicit ScopeTimer(const char* name, bool enabled
= true)
constructor has two params, is 'explicit' still needed?

https://codereview.chromium.org/864173008/diff/1/runtime/vm/scope_timer.h#new...
runtime/vm/scope_timer.h:39: int64_t start_;
Missing the boiler plate DISALLOW stuff.

[Cutch, 2015-02-09 23:22:07]

https://codereview.chromium.org/864173008/diff/1/runtime/vm/scope_timer.h
File runtime/vm/scope_timer.h (right):

https://codereview.chromium.org/864173008/diff/1/runtime/vm/scope_timer.h#new...
runtime/vm/scope_timer.h:13: explicit ScopeTimer(const char* name, bool enabled
= true)
On 2015/02/09 23:19:59, siva wrote:
> constructor has two params, is 'explicit' still needed?

Acknowledged.

https://codereview.chromium.org/864173008/diff/1/runtime/vm/scope_timer.h#new...
runtime/vm/scope_timer.h:39: int64_t start_;
On 2015/02/09 23:19:59, siva wrote:
> Missing the boiler plate DISALLOW stuff.

Acknowledged.

[Cutch, 2015-02-09 23:22:37]

Committed patchset #1 (id:1) manually as 43623 (presubmit successful).

[RobertCNelson, 2015-02-17 23:51:17]

On 2015/02/09 23:22:37, Cutch wrote:
> Committed patchset #1 (id:1) manually as 43623 (presubmit successful).

This commit is breaking Debian Jessie:

dart-edge$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-linux-gnueabihf/4.9/lto-wrapper
Target: arm-linux-gnueabihf
Configured with: ../src/configure -v --with-pkgversion='Debian 4.9.1-19'
--with-bugurl=file:///usr/share/doc/gcc-4.9/README.Bugs
--enable-languages=c,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr
--program-suffix=-4.9 --enable-shared --enable-linker-build-id
--libexecdir=/usr/lib --without-included-gettext --enable-threads=posix
--with-gxx-include-dir=/usr/include/c++/4.9 --libdir=/usr/lib --enable-nls
--with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug
--enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libitm
--disable-libquadmath --enable-plugin --with-system-zlib
--disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-4.9-armhf/jre --enable-java-home
--with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-4.9-armhf
--with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-4.9-armhf
--with-arch-directory=arm --with-ecj-jar=/usr/share/java/eclipse-ecj.jar
--enable-objc-gc --enable-multiarch --disable-sjlj-exceptions
--with-arch=armv7-a --with-fpu=vfpv3-d16 --with-float=hard --with-mode=thumb
--enable-checking=release --build=arm-linux-gnueabihf --host=arm-linux-gnueabihf
--target=arm-linux-gnueabihf
Thread model: posix
gcc version 4.9.1 (Debian 4.9.1-19


  g++ '-DTARGET_ARCH_ARM' '-DNDEBUG' -Iruntime  -Werror -Wall -Wextra
-Wno-unused-parameter -Wnon-virtual-dtor -Wvla -Wno-conversion-null
-Woverloaded-virtual -g3 -ggdb3 -fno-rtti -fno-exceptions -marm -mfpu=vfp
-Wno-psabi -fno-strict-overflow -O3  -MMD -MF
out/ReleaseARM/.deps/out/ReleaseARM/obj.host/libdart_vm/runtime/vm/profiler_service.o.d.raw
 -c -o out/ReleaseARM/obj.host/libdart_vm/runtime/vm/profiler_service.o
runtime/vm/profiler_service.cc
In file included from runtime/vm/profiler_service.cc:13:0:
runtime/vm/scope_timer.h: In static member function 'static void
dart::ProfilerService::PrintJSON(dart::JSONStream*,
dart::ProfilerService::TagOrder)':
runtime/vm/scope_timer.h:25:18: error: 'sw.dart::ScopeTimer::start_' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
     return end - start_;
                  ^
runtime/vm/profiler_service.cc:1278:20: note: 'sw.dart::ScopeTimer::start_' was
declared here
         ScopeTimer sw("CodeRegionTableBuilder", FLAG_trace_profiler);
                    ^
In file included from runtime/vm/profiler_service.cc:13:0:
runtime/vm/scope_timer.h:25:18: error: 'sw.dart::ScopeTimer::start_' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
     return end - start_;
                  ^
runtime/vm/profiler_service.cc:1270:20: note: 'sw.dart::ScopeTimer::start_' was
declared here
         ScopeTimer sw("FixTopFrame", FLAG_trace_profiler);
                    ^
cc1plus: all warnings being treated as errors
runtime/libdart_vm.host.mk:1132: recipe for target
'out/ReleaseARM/obj.host/libdart_vm/runtime/vm/profiler_service.o' failed
make[2]: *** [out/ReleaseARM/obj.host/libdart_vm/runtime/vm/profiler_service.o]
Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/«PKGBUILDDIR»/dart'
make -j 2 BUILDTYPE=ReleaseARM V=1 runtime
BUILD FAILED
make[1]: Leaving directory '/«PKGBUILDDIR»'

Regards,