Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: runtime/vm/service.cc

Issue 864173008: Split profiler.cc into profiler.cc and profiler_service.cc (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index c39d342047f0d6e8cf5ffc35d455873254d17f2f..c5e94ebbc0b484ccd2b3525dc95ebadf36b7e0c1 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -25,7 +25,7 @@
#include "vm/object_store.h"
#include "vm/parser.h"
#include "vm/port.h"
-#include "vm/profiler.h"
+#include "vm/profiler_service.h"
#include "vm/reusable_handles.h"
#include "vm/stack_frame.h"
#include "vm/symbols.h"
@@ -2238,27 +2238,24 @@ static bool HandleIsolateGetTagProfile(Isolate* isolate, JSONStream* js) {
}
static bool HandleIsolateGetCpuProfile(Isolate* isolate, JSONStream* js) {
- // A full profile includes disassembly of all Dart code objects.
- // TODO(johnmccutchan): Add option to trigger full code dump.
- bool full_profile = false;
- Profiler::TagOrder tag_order = Profiler::kUserVM;
+ ProfilerService::TagOrder tag_order = ProfilerService::kUserVM;
if (js->HasParam("tags")) {
if (js->ParamIs("tags", "None")) {
- tag_order = Profiler::kNoTags;
+ tag_order = ProfilerService::kNoTags;
} else if (js->ParamIs("tags", "UserVM")) {
- tag_order = Profiler::kUserVM;
+ tag_order = ProfilerService::kUserVM;
} else if (js->ParamIs("tags", "UserOnly")) {
- tag_order = Profiler::kUser;
+ tag_order = ProfilerService::kUser;
} else if (js->ParamIs("tags", "VMUser")) {
- tag_order = Profiler::kVMUser;
+ tag_order = ProfilerService::kVMUser;
} else if (js->ParamIs("tags", "VMOnly")) {
- tag_order = Profiler::kVM;
+ tag_order = ProfilerService::kVM;
} else {
PrintInvalidParamError(js, "tags");
return true;
}
}
- Profiler::PrintJSON(isolate, js, full_profile, tag_order);
+ ProfilerService::PrintJSON(js, tag_order);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698