Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1656)

Issue 863713003: Cleanup inconsistent dart:html method signatures (Closed)

Created:
5 years, 11 months ago by Jacob
Modified:
5 years, 11 months ago
Reviewers:
Alan Knight, terry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : ptal #

Patch Set 3 : ptal #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +9 lines, -4 lines 2 comments Download
M sdk/lib/html/html_common/css_class_set.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jacob
5 years, 11 months ago (2015-01-20 22:20:07 UTC) #2
Alan Knight
With the qualification that I really don't understand all of this, LGTM. https://codereview.chromium.org/863713003/diff/40001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart ...
5 years, 11 months ago (2015-01-20 22:53:01 UTC) #3
Jacob
https://codereview.chromium.org/863713003/diff/40001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/863713003/diff/40001/sdk/lib/html/dartium/html_dartium.dart#oldcode31422 sdk/lib/html/dartium/html_dartium.dart:31422: - if ((blob_OR_source_OR_stream is MediaSource)) { On 2015/01/20 22:53:01, ...
5 years, 11 months ago (2015-01-20 23:00:20 UTC) #4
Jacob
5 years, 11 months ago (2015-01-20 23:05:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 43029 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698