Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 863713003: Cleanup inconsistent dart:html method signatures (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: ptal Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | sdk/lib/html/dartium/html_dartium.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 54ef35fe60cd4dd34c76ef4aa14ac8dfbc980dcd..9ce36d608a640827c9bd66104b7f798550a4c6a7 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -10066,7 +10066,12 @@ abstract class ElementList<T extends Element> extends ListBase<T> {
}
-// Wrapper over an immutable NodeList to make it implement ElementList<Element>.
+// Wrapper over an immutable NodeList to make it implement ElementList.
+//
+// Clients are {`Document`, `DocumentFragment`}.`querySelectorAll` which are
+// declared to return `ElementList`. This provides all the static analysis
+// benefit so there is no need for this class have a constrained type parameter.
+//
class _FrozenElementList extends ListBase
implements ElementList, NodeListWrapper {
final List<Node> _nodeList;
@@ -23008,7 +23013,7 @@ abstract class ParentNode extends Interceptor {
Element querySelector(String selectors);
- List<Node> querySelectorAll(String selectors);
+ List<Node> _querySelectorAll(String selectors);
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
« no previous file with comments | « no previous file | sdk/lib/html/dartium/html_dartium.dart » ('j') | sdk/lib/html/dartium/html_dartium.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698