Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 862133006: Add tests for additional bugs fixed by r43163. (Closed)

Created:
5 years, 10 months ago by Paul Berry
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for additional bugs fixed by r43163. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43168

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -0 lines) Patch
M pkg/analysis_server/test/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/analysis/update_content_test.dart View 1 chunk +92 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 10 months ago (2015-01-27 00:59:32 UTC) #2
scheglov
LGTM https://codereview.chromium.org/862133006/diff/1/pkg/analysis_server/test/analysis/update_content_test.dart File pkg/analysis_server/test/analysis/update_content_test.dart (right): https://codereview.chromium.org/862133006/diff/1/pkg/analysis_server/test/analysis/update_content_test.dart#newcode51 pkg/analysis_server/test/analysis/update_content_test.dart:51: resourceProvider.newFolder('/project1'); You don't need to do this. MemoryResourceProvider ...
5 years, 10 months ago (2015-01-27 01:05:22 UTC) #3
Paul Berry
https://codereview.chromium.org/862133006/diff/1/pkg/analysis_server/test/analysis/update_content_test.dart File pkg/analysis_server/test/analysis/update_content_test.dart (right): https://codereview.chromium.org/862133006/diff/1/pkg/analysis_server/test/analysis/update_content_test.dart#newcode51 pkg/analysis_server/test/analysis/update_content_test.dart:51: resourceProvider.newFolder('/project1'); On 2015/01/27 01:05:22, scheglov wrote: > You don't ...
5 years, 10 months ago (2015-01-27 01:07:20 UTC) #4
Paul Berry
5 years, 10 months ago (2015-01-27 01:10:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 43168 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698