Add tests for additional bugs fixed by r43163.

pkg/analysis_server/test/analysis/update_content_test.dart

Index: pkg/analysis_server/test/analysis/update_content_test.dart
diff --git a/pkg/analysis_server/test/analysis/update_content_test.dart b/pkg/analysis_server/test/analysis/update_content_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..43f023503ad87099116c622a62676a6eafd7c640
--- /dev/null
+++ b/pkg/analysis_server/test/analysis/update_content_test.dart
@@ -0,0 +1,92 @@
+// Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library test.analysis.updateContent;
+
+import 'package:analysis_server/src/constants.dart';
+import 'package:analysis_server/src/protocol.dart';
+import 'package:unittest/unittest.dart';
+
+import '../analysis_abstract.dart';
+import '../reflective_tests.dart';
+
+
+main() {
+  groupSep = ' | ';
+  runReflectiveTests(UpdateContentTest);
+}
+
+
+@reflectiveTest
+class UpdateContentTest extends AbstractAnalysisTest {
+  Map<String, List<AnalysisError>> filesErrors = {};
+
+  @override
+  void processNotification(Notification notification) {
+    if (notification.event == ANALYSIS_ERRORS) {
+      var decoded = new AnalysisErrorsParams.fromNotification(notification);
+      filesErrors[decoded.file] = decoded.errors;
+    }
+  }
+
+  test_illegal_ChangeContentOverlay() {
+    // It should be illegal to send a ChangeContentOverlay for a file that
+    // doesn't have an overlay yet.
+    createProject();
+    addTestFile('library foo;');
+    String id = 'myId';
+    try {
+      server.updateContent(id, {
+        testFile: new ChangeContentOverlay([new SourceEdit(8, 3, 'bar')])
+      });
+      fail('Expected an exception to be thrown');
+    } on RequestFailure catch (e) {
+      expect(e.response.id, id);
+      expect(e.response.error.code, RequestErrorCode.INVALID_OVERLAY_CHANGE);
+    }
+  }
+
+  test_multiple_contexts() {
+    resourceProvider.newFolder('/project1');

[scheglov, 2015/01/27 01:05:22]

You don't need to do this.
MemoryResourceProvider creates folders automatically.

[Paul Berry, 2015/01/27 01:07:19]

Ok, thanks.  I've removed the unnecessary code.

+    String fooPath = '/project1/foo.dart';
+    resourceProvider.newFile(fooPath, '''
+library foo;
+import '../project2/baz.dart';
+main() { f(); }''');
+    resourceProvider.newFolder('/project2');
+    String barPath = '/project2/bar.dart';
+    resourceProvider.newFile(barPath, '''
+library bar;
+import 'baz.dart';
+main() { f(); }''');
+    String bazPath = '/project2/baz.dart';
+    resourceProvider.newFile(bazPath, '''
+library baz;
+f(int i) {}
+''');
+    Request request = new AnalysisSetAnalysisRootsParams(
+        ['/project1', '/project2'],
+        []).toRequest('0');
+    handleSuccessfulRequest(request);
+    return waitForTasksFinished().then((_) {
+      // Files foo.dart and bar.dart should both have errors, since they both
+      // call f() with the wrong number of arguments.
+      expect(filesErrors[fooPath], hasLength(1));
+      expect(filesErrors[barPath], hasLength(1));
+      // Overlay the content of baz.dart to eliminate the errors.
+      server.updateContent('1', {
+        bazPath: new AddContentOverlay('''
+library baz;
+f() {}
+''')
+      });
+      return waitForTasksFinished();
+    }).then((_) {
+      // The overlay should have been propagated to both contexts, causing both
+      // foo.dart and bar.dart to be reanalyzed and found to be free of errors.
+      expect(filesErrors[fooPath], isEmpty);
+      expect(filesErrors[barPath], isEmpty);
+    });
+  }
+}