Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 860723002: cleanup to status_reporter (Closed)

Created:
5 years, 11 months ago by kevmoo
Modified:
5 years, 11 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

cleanup to status_reporter Infer build architectures from combinations Print build command Fix comments R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=43016

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Patch Set 3 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M tools/testing/dart/status_reporter.dart View 1 2 3 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kevmoo
5 years, 11 months ago (2015-01-19 23:56:09 UTC) #2
ricow1
lgtm, thanks https://codereview.chromium.org/860723002/diff/1/tools/testing/dart/status_reporter.dart File tools/testing/dart/status_reporter.dart (right): https://codereview.chromium.org/860723002/diff/1/tools/testing/dart/status_reporter.dart#newcode102 tools/testing/dart/status_reporter.dart:102: print(args.join(' ')); print('Running: python ${args.join(" ")}'); https://codereview.chromium.org/860723002/diff/1/tools/testing/dart/status_reporter.dart#newcode137 ...
5 years, 11 months ago (2015-01-20 06:15:05 UTC) #3
kevmoo
https://codereview.chromium.org/860723002/diff/1/tools/testing/dart/status_reporter.dart File tools/testing/dart/status_reporter.dart (right): https://codereview.chromium.org/860723002/diff/1/tools/testing/dart/status_reporter.dart#newcode102 tools/testing/dart/status_reporter.dart:102: print(args.join(' ')); On 2015/01/20 06:15:05, ricow1 wrote: > print('Running: ...
5 years, 11 months ago (2015-01-20 16:48:10 UTC) #4
kevmoo
5 years, 11 months ago (2015-01-20 16:49:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 43016 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698