send priority instrumentation message on startup with version info

send priority instrumentation message on startup with version info

BUG=
R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43017

[danrubel, 2015-01-16 18:54:12]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com, lukechurch@google.com

[danrubel, 2015-01-16 18:54:13]

https://codereview.chromium.org/859513002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/server/driver.dart (right):

https://codereview.chromium.org/859513002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/server/driver.dart:351:
'.instrumentation').getChild('uuid.txt').path);
Is this the correct location to cache the UUID ?

[Brian Wilkerson, 2015-01-16 19:48:28]

LGTM

https://codereview.chromium.org/859513002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/server/driver.dart (right):

https://codereview.chromium.org/859513002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/server/driver.dart:351:
'.instrumentation').getChild('uuid.txt').path);
I think so.

https://codereview.chromium.org/859513002/diff/20001/pkg/analyzer/lib/instrum...
File pkg/analyzer/lib/instrumentation/instrumentation.dart (right):

https://codereview.chromium.org/859513002/diff/20001/pkg/analyzer/lib/instrum...
pkg/analyzer/lib/instrumentation/instrumentation.dart:64: static const String
TAG_STARTUP = 'Startup';
This is what "TAG_VERSION" was added for.

[Brian Wilkerson, 2015-01-17 18:08:24]

https://codereview.chromium.org/859513002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/constants.dart (right):

https://codereview.chromium.org/859513002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/constants.dart:7: const String
ANALYSIS_SERVER_VERSION = '0.0.1';
On an experimental branch that I'm working on I ran into the same need for
making this a constant. I chose to add "AnalysisServer.VERSION" rather than put
it here. That seems cleaner to me, in part because it feels like the contents of
this file could be auto-generated from the spec (except for this new constant).

[danrubel, 2015-01-20 17:23:55]

https://codereview.chromium.org/859513002/diff/20001/pkg/analysis_server/lib/...
File pkg/analysis_server/lib/src/constants.dart (right):

https://codereview.chromium.org/859513002/diff/20001/pkg/analysis_server/lib/...
pkg/analysis_server/lib/src/constants.dart:7: const String
ANALYSIS_SERVER_VERSION = '0.0.1';
On 2015/01/17 18:08:24, Brian Wilkerson wrote:
> On an experimental branch that I'm working on I ran into the same need for
> making this a constant. I chose to add "AnalysisServer.VERSION" rather than
put
> it here. That seems cleaner to me, in part because it feels like the contents
of
> this file could be auto-generated from the spec (except for this new
constant).

That works for me. Moved.

https://codereview.chromium.org/859513002/diff/20001/pkg/analyzer/lib/instrum...
File pkg/analyzer/lib/instrumentation/instrumentation.dart (right):

https://codereview.chromium.org/859513002/diff/20001/pkg/analyzer/lib/instrum...
pkg/analyzer/lib/instrumentation/instrumentation.dart:64: static const String
TAG_STARTUP = 'Startup';
On 2015/01/16 19:48:28, Brian Wilkerson wrote:
> This is what "TAG_VERSION" was added for.

Good to know. Switched to using that instead.

[danrubel, 2015-01-20 17:30:53]

Committed patchset #3 (id:40001) manually as 43017 (presubmit successful).