Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 855643004: Use UTF-8 when serving web pages for analysis server debug. (Closed)

Created:
5 years, 11 months ago by Paul Berry
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Use UTF-8 when serving web pages for analysis server debug. This avoids the need to encode unicode characters using hexadecimal escape sequences. (Note that setting the charset using response.headers.contentType affects the encoding used by both client and server.) R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=43045

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -72 lines) Patch
M pkg/analysis_server/lib/src/get_handler.dart View 9 chunks +18 lines, -9 lines 2 comments Download
M pkg/analysis_server/lib/src/server/http_server.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/ast_writer.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/element_writer.dart View 2 chunks +3 lines, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/status/utilities.dart View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
5 years, 11 months ago (2015-01-21 00:14:44 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/855643004/diff/1/pkg/analysis_server/lib/src/get_handler.dart File pkg/analysis_server/lib/src/get_handler.dart (right): https://codereview.chromium.org/855643004/diff/1/pkg/analysis_server/lib/src/get_handler.dart#newcode356 pkg/analysis_server/lib/src/get_handler.dart:356: new ContentType("text", "html", charset: "utf-8"); Can we use ...
5 years, 11 months ago (2015-01-21 00:27:09 UTC) #3
Paul Berry
https://codereview.chromium.org/855643004/diff/1/pkg/analysis_server/lib/src/get_handler.dart File pkg/analysis_server/lib/src/get_handler.dart (right): https://codereview.chromium.org/855643004/diff/1/pkg/analysis_server/lib/src/get_handler.dart#newcode356 pkg/analysis_server/lib/src/get_handler.dart:356: new ContentType("text", "html", charset: "utf-8"); On 2015/01/21 00:27:09, Brian ...
5 years, 11 months ago (2015-01-21 17:57:37 UTC) #4
Paul Berry
5 years, 11 months ago (2015-01-21 17:58:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698