pkg/analysis_server/lib/src/get_handler.dart - Issue 855643004: Use UTF-8 when serving web pages for analysis server debug.

Unified Diff: pkg/analysis_server/lib/src/get_handler.dart

Issue 855643004: Use UTF-8 when serving web pages for analysis server debug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/get_handler.dart

diff --git a/pkg/analysis_server/lib/src/get_handler.dart b/pkg/analysis_server/lib/src/get_handler.dart

index af63297ab1eb6d84a8325d7afbde9c84f4d6fc37..bee681651233552bb8b33715e5de20d72a192162 100644

--- a/pkg/analysis_server/lib/src/get_handler.dart

+++ b/pkg/analysis_server/lib/src/get_handler.dart

@@ -352,7 +352,8 @@ class GetHandler {

HttpResponse response = request.response;

response.statusCode = HttpStatus.OK;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

Brian Wilkerson 2015/01/21 00:27:09 Can we use a static const?

Paul Berry 2015/01/21 17:57:37 It looks like the ContentType constructor is non-c

response.write('<html>');

response.write('<head>');

response.write('<title>Dart Analysis Server - Search result</title>');

@@ -527,7 +528,8 @@ class GetHandler {

}

HttpResponse response = request.response;

response.statusCode = HttpStatus.OK;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

response.write('<html>');

response.write('<head>');

response.write('<title>Dart Analysis Server - Search result</title>');

@@ -574,7 +576,8 @@ class GetHandler {

var maxCount = request.requestedUri.queryParameters['maxCount'];

HttpResponse response = request.response;

response.statusCode = HttpStatus.OK;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

response.write('<html>');

response.write('<head>');

response.write('<title>Dart Analysis Server - Completion Stats</title>');

@@ -781,7 +784,8 @@ class GetHandler {

void _returnFailure(HttpRequest request, String message) {

HttpResponse response = request.response;

response.statusCode = HttpStatus.OK;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

response.write('<html>');

response.write('<head>');

response.write('<title>Dart Analysis Server - Failure</title>');

@@ -799,7 +803,8 @@ class GetHandler {

String contents = _overlayContents[id];

HttpResponse response = request.response;

response.statusCode = HttpStatus.OK;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

response.write('<html>');

response.write('<head>');

response.write('<title>Dart Analysis Server - Overlay</title>');

@@ -821,7 +826,8 @@ class GetHandler {

}

HttpResponse response = request.response;

response.statusCode = HttpStatus.OK;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

response.write('<html>');

response.write('<head>');

response.write('<title>Dart Analysis Server - Overlays</title>');

@@ -857,7 +863,8 @@ class GetHandler {

void _returnServerStatus(HttpRequest request) {

HttpResponse response = request.response;

response.statusCode = HttpStatus.OK;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

response.write('<html>');

response.write('<head>');

response.write('<title>Dart Analysis Server - Status</title>');

@@ -979,7 +986,8 @@ class GetHandler {

void _returnUnknownRequest(HttpRequest request) {

HttpResponse response = request.response;

response.statusCode = HttpStatus.NOT_FOUND;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

response.write('<html>');

response.write('<head>');

response.write('<title>Dart Analysis Server - Page Not Found</title>');

@@ -1366,7 +1374,8 @@ class GetHandler {

void _writeResponse(HttpRequest request, HtmlGenerator writePage) {

HttpResponse response = request.response;

response.statusCode = HttpStatus.OK;

- response.headers.add(HttpHeaders.CONTENT_TYPE, "text/html");

+ response.headers.contentType =

+ new ContentType("text", "html", charset: "utf-8");

try {

StringBuffer buffer = new StringBuffer();

try {

« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/server/http_server.dart » ('j') | no next file with comments »