Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 853353004: http_parser: update unittest dependency, urls in pubspec and codereview (Closed)

Created:
5 years, 11 months ago by kevmoo
Modified:
5 years, 11 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/http_parser.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

http_parser: update unittest dependency, urls in pubspec and codereview remove unused variable R=nweiz@google.com Committed: https://github.com/dart-lang/http_parser/commit/5b815dceda510a314494c179ca28eb5bdc3b4f63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M codereview.settings View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/web_socket.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pubspec.yaml View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kevmoo
5 years, 11 months ago (2015-01-17 22:57:43 UTC) #2
nweiz
lgtm
5 years, 11 months ago (2015-01-20 23:24:18 UTC) #3
kevmoo
5 years, 11 months ago (2015-01-21 00:21:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b815dceda510a314494c179ca28eb5bdc3b4f63 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698