lib/src/web_socket.dart - Issue 853353004: http_parser: update unittest dependency, urls in pubspec and codereview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/web_socket.dart

Issue 853353004: http_parser: update unittest dependency, urls in pubspec and codereview (Closed) Base URL: https://github.com/dart-lang/http_parser.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/src/web_socket.dart

diff --git a/lib/src/web_socket.dart b/lib/src/web_socket.dart

index 77c9d2b873a41e2c6875f866c95ba748ceae7acf..968c70b0e13dd0606b2e75309425c41b84fc5cf6 100644

--- a/lib/src/web_socket.dart

+++ b/lib/src/web_socket.dart

@@ -592,7 +592,6 @@ class _WebSocketOutgoingTransformer implements StreamTransformer, EventSink {

header[index++] = 0x80 | opcode;

// Determine size and position of length field.

int lengthBytes = 1;

- int firstLengthByte = 1;

if (dataLength > 65535) {

header[index++] = 127;

lengthBytes = 8;

« no previous file with comments | « codereview.settings ('k') | pubspec.yaml » ('j') | no next file with comments »