Issue 85333006: Profiler fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 85333006: Profiler fixes (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

- Fix MonitorData ASSERT failure in thread_win: E:\b\build\slave\vm-win32-debug-russian-be\build\dart\runtime\platform/thread_win.h:66: error: expected: next_ == NULL. - Reduce sample buffer size by an order of magnitude (this should fix . - Disable profiler on simulators. - Only sample when scheduled thread id matches current thread id. Committed: https://code.google.com/p/dart/source/detail?r=30647

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -37 lines)			Patch
M	runtime/platform/thread_win.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/profiler.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/profiler.cc	View	5 chunks	+12 lines, -3 lines	0 comments	Download
M	runtime/vm/profiler_android.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	runtime/vm/profiler_linux.cc	View	1 chunk	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/profiler_macos.cc	View	1 chunk	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/profiler_win.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

LGTM -ip

Expand Messages | Collapse Messages