Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: runtime/vm/profiler_android.cc

Issue 85333006: Profiler fixes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler.cc ('k') | runtime/vm/profiler_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler_android.cc
diff --git a/runtime/vm/profiler_android.cc b/runtime/vm/profiler_android.cc
index 1392739ddc066e6141c6cdd312df4b24a7f8d1e5..5d9167cadae2d8bf42a07feb79b57394445e0737 100644
--- a/runtime/vm/profiler_android.cc
+++ b/runtime/vm/profiler_android.cc
@@ -28,13 +28,15 @@ static void ProfileSignalAction(int signal, siginfo_t* info, void* context_) {
// Thread owns isolate profiler data mutex.
ScopedMutex profiler_data_lock(isolate->profiler_data_mutex());
IsolateProfilerData* profiler_data = isolate->profiler_data();
- if (profiler_data == NULL) {
- return;
- }
- if (!profiler_data->CanExpire()) {
+ if ((profiler_data == NULL) || !profiler_data->CanExpire() ||
+ (profiler_data->sample_buffer() == NULL)) {
// Descheduled.
return;
}
+ if (profiler_data->thread_id() == Thread::GetCurrentThreadId()) {
+ // Still scheduled on this thread.
+ // TODO(johnmccutchan): Perform sample on Android.
+ }
}
// Thread owns no profiler locks at this point.
// This call will acquire both ProfilerManager::monitor and the
« no previous file with comments | « runtime/vm/profiler.cc ('k') | runtime/vm/profiler_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698