Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 851793002: dart2js: Rename Fragment to LibrariesMap and Output to Fragment. (Closed)

Created:
5 years, 11 months ago by floitsch
Modified:
5 years, 11 months ago
Reviewers:
zarah
CC:
reviews_dartlang.org, kasperl
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Rename Fragment to LibrariesMap and Output to Fragment. Fragment is the better name and is now used more often. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42863

Patch Set 1 #

Patch Set 2 : Undo bad rename. #

Patch Set 3 : A few more renames. #

Patch Set 4 : Fix long line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -126 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 1 3 chunks +35 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 2 6 chunks +32 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 6 chunks +39 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/registry.dart View 1 2 3 3 chunks +35 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
While trying to use the model in the old emitter I started to clash with ...
5 years, 11 months ago (2015-01-13 20:52:19 UTC) #2
zarah
LGTM
5 years, 11 months ago (2015-01-14 09:46:05 UTC) #3
floitsch
5 years, 11 months ago (2015-01-14 12:57:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 42863 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698