Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: pkg/compiler/lib/src/js_emitter/model.dart

Issue 851793002: dart2js: Rename Fragment to LibrariesMap and Output to Fragment. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix long line. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/model.dart
diff --git a/pkg/compiler/lib/src/js_emitter/model.dart b/pkg/compiler/lib/src/js_emitter/model.dart
index 42597a0f220a1cd5775eded015ce1252fb254569..75ad0f1e9b7d2b7ed6b3140e6eca4c8c7eb77ffc 100644
--- a/pkg/compiler/lib/src/js_emitter/model.dart
+++ b/pkg/compiler/lib/src/js_emitter/model.dart
@@ -10,12 +10,12 @@ import '../constants/values.dart' show ConstantValue;
import '../common.dart';
class Program {
- final List<Output> outputs;
+ final List<Fragment> fragments;
final bool outputContainsConstantList;
- /// A map from load id to the list of outputs that need to be loaded.
- final Map<String, List<Output>> loadMap;
+ /// A map from load id to the list of fragments that need to be loaded.
+ final Map<String, List<Fragment>> loadMap;
- Program(this.outputs, this.outputContainsConstantList, this.loadMap);
+ Program(this.fragments, this.outputContainsConstantList, this.loadMap);
}
/**
@@ -31,11 +31,12 @@ class Holder {
/**
* This class represents one output file.
*
- * If no library is deferred, there is only one [Output] of type [MainOutput].
+ * If no library is deferred, there is only one [Fragment] of type
+ * [MainFragment].
*/
-abstract class Output {
- bool get isMainOutput => mainOutput == this;
- MainOutput get mainOutput;
+abstract class Fragment {
+ bool get isMainFragment => mainFragment == this;
+ MainFragment get mainFragment;
final List<Library> libraries;
final List<Constant> constants;
// TODO(floitsch): should we move static fields into libraries or classes?
@@ -46,55 +47,55 @@ abstract class Output {
/// Output file name without extension.
final String outputFileName;
- Output(this.outputFileName,
- this.libraries,
- this.staticNonFinalFields,
- this.staticLazilyInitializedFields,
- this.constants);
+ Fragment(this.outputFileName,
+ this.libraries,
+ this.staticNonFinalFields,
+ this.staticLazilyInitializedFields,
+ this.constants);
}
/**
* The main output file.
*
- * This code emitted from this [Output] must be loaded first. It can then load
- * other [DeferredOutput]s.
+ * This code emitted from this [Fragment] must be loaded first. It can then load
+ * other [DeferredFragment]s.
*/
-class MainOutput extends Output {
+class MainFragment extends Fragment {
final js.Expression main;
final List<Holder> holders;
- MainOutput(String outputFileName,
- this.main,
- List<Library> libraries,
- List<StaticField> staticNonFinalFields,
- List<StaticField> staticLazilyInitializedFields,
- List<Constant> constants,
- this.holders)
+ MainFragment(String outputFileName,
+ this.main,
+ List<Library> libraries,
+ List<StaticField> staticNonFinalFields,
+ List<StaticField> staticLazilyInitializedFields,
+ List<Constant> constants,
+ this.holders)
: super(outputFileName,
libraries,
staticNonFinalFields,
staticLazilyInitializedFields,
constants);
- MainOutput get mainOutput => this;
+ MainFragment get mainFragment => this;
}
/**
* An output (file) for deferred code.
*/
-class DeferredOutput extends Output {
- final MainOutput mainOutput;
+class DeferredFragment extends Fragment {
+ final MainFragment mainFragment;
final String name;
- List<Holder> get holders => mainOutput.holders;
+ List<Holder> get holders => mainFragment.holders;
- DeferredOutput(String outputFileName,
- this.name,
- this.mainOutput,
- List<Library> libraries,
- List<StaticField> staticNonFinalFields,
- List<StaticField> staticLazilyInitializedFields,
- List<Constant> constants)
+ DeferredFragment(String outputFileName,
+ this.name,
+ this.mainFragment,
+ List<Library> libraries,
+ List<StaticField> staticNonFinalFields,
+ List<StaticField> staticLazilyInitializedFields,
+ List<Constant> constants)
: super(outputFileName,
libraries,
staticNonFinalFields,
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698