Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 850343006: Linter API updates. (Closed)

Created:
5 years, 11 months ago by pquitslund
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Linter API updates. (A trimmed down version of: https://codereview.chromium.org//853123002 in a hopes of not unsettling the build.) R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43023

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -150 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 2 1 chunk +0 lines, -50 lines 0 comments Download
A pkg/analyzer/lib/src/services/lint.dart View 1 1 chunk +64 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 2 9 chunks +99 lines, -100 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 11 months ago (2015-01-20 19:16:00 UTC) #2
scheglov
LGTM
5 years, 11 months ago (2015-01-20 19:17:26 UTC) #3
Brian Wilkerson
LGTM
5 years, 11 months ago (2015-01-20 19:22:13 UTC) #4
pquitslund
5 years, 11 months ago (2015-01-20 19:38:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r43023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698