Lint contribution refactoring.

Lint contribution refactoring.

A little shuffle to centralize the linter concern (and reduce the need to touch resolver.dart).

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42967

[pquitslund, 2015-01-16 00:18:26]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2015-01-16 00:30:20]

lgtm

https://codereview.chromium.org/853123002/diff/40001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/lint.dart (right):

https://codereview.chromium.org/853123002/diff/40001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/lint.dart:41: : _linters = linters != null ?
linters : LINTERS;
Strange format...

[scheglov, 2015-01-16 00:30:22]

lgtm

[pquitslund, 2015-01-16 00:43:21]

https://codereview.chromium.org/853123002/diff/40001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/lint.dart (right):

https://codereview.chromium.org/853123002/diff/40001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/lint.dart:41: : _linters = linters != null ?
linters : LINTERS;
On 2015/01/16 00:30:20, scheglov wrote:
> Strange format...

Done.

[Brian Wilkerson, 2015-01-16 01:18:57]

LGTM

https://codereview.chromium.org/853123002/diff/60001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/visitors.dart (left):

https://codereview.chromium.org/853123002/diff/60001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/visitors.dart:9: /// An [AstVisitor] that
delegates calls to visit methods to all [delegates]
I'm surprised that this is going away. I'll be interested to hear why we no
longer need it.

https://codereview.chromium.org/853123002/diff/60001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/lint.dart (right):

https://codereview.chromium.org/853123002/diff/60001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/lint.dart:26: /// Traverses a library's worth of
dart code at a time to generate lint warnings
I think I missed this before, but in some future CL we need to change this so
that the lint generator runs over a single file at a time.

[pquitslund, 2015-01-16 18:16:36]

Thank you!

https://codereview.chromium.org/853123002/diff/60001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/visitors.dart (left):

https://codereview.chromium.org/853123002/diff/60001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/visitors.dart:9: /// An [AstVisitor] that
delegates calls to visit methods to all [delegates]
On 2015/01/16 01:18:57, Brian Wilkerson wrote:
> I'm surprised that this is going away. I'll be interested to hear why we no
> longer need it.

Not deleted.  Just moved! :)

https://codereview.chromium.org/853123002/diff/60001/pkg/analyzer/lib/src/ser...
File pkg/analyzer/lib/src/services/lint.dart (right):

https://codereview.chromium.org/853123002/diff/60001/pkg/analyzer/lib/src/ser...
pkg/analyzer/lib/src/services/lint.dart:26: /// Traverses a library's worth of
dart code at a time to generate lint warnings
On 2015/01/16 01:18:57, Brian Wilkerson wrote:
> I think I missed this before, but in some future CL we need to change this so
> that the lint generator runs over a single file at a time.

Sure thing.  I can update that in a future change.

[pquitslund, 2015-01-16 18:29:48]

Committed patchset #4 (id:60001) manually as r42967 (presubmit successful).