Remove use of deprecated mirror API from pkg/unittest.

Remove use of deprecated mirror API from pkg/unittest.

R=gbracha@google.com, sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30650

[rmacnak, 2013-11-25 19:54:00]

https://codereview.chromium.org/84993006/diff/1/pkg/unittest/lib/mirror_match...
File pkg/unittest/lib/mirror_matchers.dart (right):

https://codereview.chromium.org/84993006/diff/1/pkg/unittest/lib/mirror_match...
pkg/unittest/lib/mirror_matchers.dart:56: candidate.isStatic) {
This last clause changes the behavior. Presumably you only meant to test for an
instance getter.

[gbracha, 2013-11-25 19:55:46]

lgtm

[Siggi Cherem (dart-lang), 2013-11-25 20:28:47]

https://codereview.chromium.org/84993006/diff/1/pkg/unittest/lib/mirror_match...
File pkg/unittest/lib/mirror_matchers.dart (right):

https://codereview.chromium.org/84993006/diff/1/pkg/unittest/lib/mirror_match...
pkg/unittest/lib/mirror_matchers.dart:54: candidate is! MethodMirror ||
shouldn't we exclude if candidate is a VariableMirror?

https://codereview.chromium.org/84993006/diff/1/pkg/unittest/lib/mirror_match...
pkg/unittest/lib/mirror_matchers.dart:56: candidate.isStatic) {
On 2013/11/25 19:54:01, Ryan Macnak wrote:
> This last clause changes the behavior. Presumably you only meant to test for
an
> instance getter.

Makes sense, sgtm. Could we however split this check separately so we can
display an appropriate error message below?

[rmacnak, 2013-11-25 21:44:15]

Like so?

[Siggi Cherem (dart-lang), 2013-11-25 22:15:20]

looks great. It might be a good idea to add a couple tests for these changes in:

pkg/unittest/test/mirror_matchers_test.dart

But even as it is, lgtm!

[rmacnak, 2013-11-25 22:34:13]

On 2013/11/25 22:15:20, Siggi Cherem (dart-lang) wrote:
> looks great. It might be a good idea to add a couple tests for these changes
in:
> 
> pkg/unittest/test/mirror_matchers_test.dart

Done.

[rmacnak, 2013-11-25 22:34:38]

Committed patchset #3 manually as r30650 (presubmit successful).

[Siggi Cherem (dart-lang), 2013-11-26 00:29:12]

On 2013/11/25 22:34:13, Ryan Macnak wrote:
> On 2013/11/25 22:15:20, Siggi Cherem (dart-lang) wrote:
> > looks great. It might be a good idea to add a couple tests for these changes
> in:
> > 
> > pkg/unittest/test/mirror_matchers_test.dart
> 
> Done.

Awesome, thank you! double lgtm :-)