Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 849863002: Replace @ReflectiveTestCase() with @reflectiveTest. (Closed)

Created:
5 years, 11 months ago by scheglov
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Replace @ReflectiveTestCase() with @reflectiveTest. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42821

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -272 lines) Patch
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_occurrences_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 10 chunks +10 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_after_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_before_analysis_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_hover_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/navigation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/occurrences_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/outline_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/overrides_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/package_root_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/reanalyze_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/asynchrony_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/get_version_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_invalid_service_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/set_subscriptions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/shutdown_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/server/status_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/reflective_tests.dart View 3 chunks +11 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/member_references_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/arglist_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/combinator_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/keyword_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/local_computer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/change_test.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/levenshtein_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/sort_members_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/strings_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/local_index_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/collection_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/split_store_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/temporary_folder_file_manager_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_label_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/cancelable_future_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/enum_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 28 chunks +28 lines, -28 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 13 chunks +13 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 13 chunks +13 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 24 chunks +24 lines, -24 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_scanner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 26 chunks +26 lines, -26 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 11 chunks +11 lines, -11 lines 0 comments Download
M pkg/analyzer/test/instrumentation/instrumentation_test.dart View 2 chunks +4 lines, -4 lines 2 comments Download
M pkg/analyzer/test/reflective_tests.dart View 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 11 months ago (2015-01-13 16:43:13 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/849863002/diff/1/pkg/analyzer/test/instrumentation/instrumentation_test.dart File pkg/analyzer/test/instrumentation/instrumentation_test.dart (right): https://codereview.chromium.org/849863002/diff/1/pkg/analyzer/test/instrumentation/instrumentation_test.dart#newcode20 pkg/analyzer/test/instrumentation/instrumentation_test.dart:20: class InstrumentationServiceTest extends ReflectiveTest { This looks wrong. ...
5 years, 11 months ago (2015-01-13 17:06:22 UTC) #2
scheglov
https://codereview.chromium.org/849863002/diff/1/pkg/analyzer/test/instrumentation/instrumentation_test.dart File pkg/analyzer/test/instrumentation/instrumentation_test.dart (right): https://codereview.chromium.org/849863002/diff/1/pkg/analyzer/test/instrumentation/instrumentation_test.dart#newcode20 pkg/analyzer/test/instrumentation/instrumentation_test.dart:20: class InstrumentationServiceTest extends ReflectiveTest { On 2015/01/13 17:06:22, Brian ...
5 years, 11 months ago (2015-01-13 17:10:33 UTC) #3
scheglov
5 years, 11 months ago (2015-01-13 17:12:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698