Replace @ReflectiveTestCase() with @reflectiveTest.

pkg/analyzer/test/instrumentation/instrumentation_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.instrumentation;
 
 import 'package:analyzer/instrumentation/instrumentation.dart';
 import 'package:unittest/unittest.dart';
 
 import '../reflective_tests.dart';
 
 main() {
   group('instrumentation', () {
     runReflectiveTests(InstrumentationServiceTest);
     runReflectiveTests(MulticastInstrumentationServerTest);
   });
 }
 
-@ReflectiveTestCase()
-class InstrumentationServiceTest extends ReflectiveTestCase {
+@reflectiveTest
+class InstrumentationServiceTest extends ReflectiveTest {

[Brian Wilkerson, 2015/01/13 17:06:22]

This looks wrong. Why would we ever subclass the annotation class?

[scheglov, 2015/01/13 17:10:33]

Good question.
It shouldn't.
Removed.

   void assertNormal(TestInstrumentationServer server, String tag,
       String message) {
     String sent = server.normalChannel.toString();
     if (!sent.endsWith(':$tag:$message\n')) {
       fail('Expected "...:$tag:$message", found "$sent"');
     }
   }
 
   void test_logError_withColon() {
     TestInstrumentationServer server = new TestInstrumentationServer();
@@ skipping 69 matching lines @@
 
   void test_logResponse() {
     TestInstrumentationServer server = new TestInstrumentationServer();
     InstrumentationService service = new InstrumentationService(server);
     String message = 'responseText';
     service.logResponse(message);
     assertNormal(server, InstrumentationService.TAG_RESPONSE, message);
   }
 }
 
-@ReflectiveTestCase()
-class MulticastInstrumentationServerTest extends ReflectiveTestCase {
+@reflectiveTest
+class MulticastInstrumentationServerTest extends ReflectiveTest {
   TestInstrumentationServer serverA = new TestInstrumentationServer();
   TestInstrumentationServer serverB = new TestInstrumentationServer();
   MulticastInstrumentationServer server;
 
   void setUp() {
     server = new MulticastInstrumentationServer([serverA, serverB]);
   }
 
   void test_log() {
     server.log('foo bar');
@@ skipping 38 matching lines @@
   @override
   void logWithPriority(String message) {
     priorityChannel.writeln(message);
   }
 
   @override
   void shutdown() {
     // Ignored
   }
 }