Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 848333002: Register throwRuntimeError when creating an ErroneousConstructorElementX (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch, asgerf
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Register throwRuntimeError when creating an ErroneousConstructorElementX R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42912

Patch Set 1 #

Patch Set 2 : Another crash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M dart/pkg/compiler/lib/src/resolution/members.dart View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
This should fix the build bot redness.
5 years, 11 months ago (2015-01-15 13:48:07 UTC) #2
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-15 13:54:45 UTC) #3
ahe
Committed patchset #2 (id:20001) manually as 42912 (presubmit successful).
5 years, 11 months ago (2015-01-15 15:02:43 UTC) #4
ahe
PTAL at TBR patch set #2.
5 years, 11 months ago (2015-01-15 15:05:36 UTC) #5
Johnni Winther
5 years, 11 months ago (2015-01-16 08:20:59 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698