Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: dart/pkg/compiler/lib/src/resolution/members.dart

Issue 848333002: Register throwRuntimeError when creating an ErroneousConstructorElementX (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Another crash. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/compiler/lib/src/resolution/members.dart
diff --git a/dart/pkg/compiler/lib/src/resolution/members.dart b/dart/pkg/compiler/lib/src/resolution/members.dart
index 7f4edc20b71134442135500781fa9dc5d3590366..ceef4975f2d54dc320aa534ac0d049ff2c2eb73f 100644
--- a/dart/pkg/compiler/lib/src/resolution/members.dart
+++ b/dart/pkg/compiler/lib/src/resolution/members.dart
@@ -1855,7 +1855,8 @@ class TypeResolver {
visitor.warning(node, messageKind, messageArguments);
}
if (erroneousElement == null) {
- erroneousElement = new ErroneousElementX(
+ registry.registerThrowRuntimeError();
+ erroneousElement = new ErroneousElementX(
messageKind, messageArguments, typeName.source,
visitor.enclosingElement);
}
@@ -4879,6 +4880,7 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
element = new ErroneousConstructorElementX(
MessageKind.NOT_A_TYPE, {'node': diagnosticNode},
element.name, element);
+ registry.registerThrowRuntimeError();
}
if (type == null) {
@@ -4952,17 +4954,20 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
element = new ErroneousConstructorElementX(
MessageKind.CANNOT_INSTANTIATE_TYPEDEF,
{'typedefName': name}, name, resolver.enclosingElement);
+ registry.registerThrowRuntimeError();
} else if (element.isTypeVariable) {
error(node, MessageKind.CANNOT_INSTANTIATE_TYPE_VARIABLE,
{'typeVariableName': name});
element = new ErroneousConstructorElementX(
MessageKind.CANNOT_INSTANTIATE_TYPE_VARIABLE,
{'typeVariableName': name}, name, resolver.enclosingElement);
+ registry.registerThrowRuntimeError();
} else if (!element.isClass && !element.isPrefix) {
error(node, MessageKind.NOT_A_TYPE, {'node': name});
element = new ErroneousConstructorElementX(
MessageKind.NOT_A_TYPE, {'node': name}, name,
resolver.enclosingElement);
+ registry.registerThrowRuntimeError();
}
return element;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698