Issue 84813002: Profiling fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 84813002: Profiling fixes (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

- SetupIsolateForProfiling before SetCurrent is called on an isolate for the first time. - ProfilerManager::Shutdown no longer frees isolate profiling data for registered isolates. Each isolate will free its own data when shutdown. - Fix monitor timeout test to disable signal delivery. - Do not walk the call stack in signal handler. TBR Committed: https://code.google.com/p/dart/source/detail?r=30607

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -10 lines)			Patch
M	runtime/vm/isolate.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/profiler.cc	View	7 chunks	+32 lines, -8 lines	0 comments	Download
M	runtime/vm/thread_test.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r30607 (presubmit successful).

Expand Messages | Collapse Messages