Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: runtime/vm/thread_test.cc

Issue 84813002: Profiling fixes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread_test.cc
diff --git a/runtime/vm/thread_test.cc b/runtime/vm/thread_test.cc
index ff8b5635278352075d8365bb9a50d983c4ca035a..1305a1c51b3c2ad0d6d606ed0b03fdb0712274a2 100644
--- a/runtime/vm/thread_test.cc
+++ b/runtime/vm/thread_test.cc
@@ -5,6 +5,7 @@
#include "platform/assert.h"
#include "vm/isolate.h"
#include "vm/unit_test.h"
+#include "vm/signal_handler.h"
#include "vm/thread.h"
namespace dart {
@@ -42,6 +43,10 @@ UNIT_TEST_CASE(Monitor) {
const int kNumAttempts = 5;
int attempts = 0;
while (attempts < kNumAttempts) {
+ // This test verifies that a monitor returns after the specified timeout. If
+ // a signal is delivered to this thread, the monitor may return early.
+ // Block signal delivery in this scope.
+ ScopedSignalBlocker ssb;
MonitorLocker ml(monitor);
int64_t start = OS::GetCurrentTimeMillis();
int64_t wait_time = 2017;
« no previous file with comments | « runtime/vm/profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698