Issue 846553003: Support unboxed input to indirect goto instruction.

Issue 846553003: Support unboxed input to indirect goto instruction. (Closed)

Created:
5 years, 11 months ago by zerny-google

Modified:
5 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Support unboxed input to indirect goto instruction. R=vegorov@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42762

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -9 lines)			Patch
M	runtime/vm/intermediate_language.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+5 lines, -3 lines	2 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/846553003/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/846553003/diff/1/runtime/vm/intermediate_language_arm.cc#newcode6782 runtime/vm/intermediate_language_arm.cc:6782: offset()->definition()->representation() == kTagged ? consider ( ) around ...

5 years, 11 months ago (2015-01-09 15:49:22 UTC) #2

zerny-google

Thanks for the review. https://codereview.chromium.org/846553003/diff/1/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/846553003/diff/1/runtime/vm/intermediate_language_arm.cc#newcode6782 runtime/vm/intermediate_language_arm.cc:6782: offset()->definition()->representation() == kTagged ? On ...

5 years, 11 months ago (2015-01-12 06:05:14 UTC) #3

zerny-google

5 years, 11 months ago (2015-01-12 06:09:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42762 (presubmit successful).

Expand Messages | Collapse Messages