runtime/vm/intermediate_language_arm.cc - Issue 846553003: Support unboxed input to indirect goto instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 846553003: Support unboxed input to indirect goto instruction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm.cc

diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc

index 4c7d4b55711a8661767937397297c368f61c2734..74dae241067ad479c40c1112490a7ef974aa737f 100644

--- a/runtime/vm/intermediate_language_arm.cc

+++ b/runtime/vm/intermediate_language_arm.cc

@@ -6778,9 +6778,11 @@ void IndirectGotoInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

// Add the offset.

- __ add(target_address_reg,

- target_address_reg,

- Operand(offset_reg, ASR, kSmiTagSize));

+ Operand offset_opr =

+ offset()->definition()->representation() == kTagged ?

Vyacheslav Egorov (Google) 2015/01/09 15:49:21 consider ( ) around comparison.

zerny-google 2015/01/12 06:05:14 Done.

+ Operand(offset_reg, ASR, kSmiTagSize) :

+ Operand(offset_reg);

+ __ add(target_address_reg, target_address_reg, offset_opr);

// Jump to the absolute address.

__ bx(target_address_reg);

« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_arm64.cc » ('j') | no next file with comments »