Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 845973006: Addition of AnalysisServer.isSocketOpen for clients to know if the server is still running. (Closed)

Created:
5 years, 11 months ago by jwren
Modified:
5 years, 11 months ago
CC:
reviews_dartlang.org, ricow1, keertip, Brian Wilkerson
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Addition of AnalysisServer.isSocketOpen for clients to know if the server is still running. Execution of generate_all for recent changes to the analyzer spec input, and resulting changes to have editor and the java server layer compile. R=paulberry@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -22 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServerSocket.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java View 7 chunks +27 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java View 2 chunks +4 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 1 chunk +4 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java View 1 chunk +12 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 6 chunks +8 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/TestServerSocket.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java View 1 chunk +6 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/AnalysisServerDataImpl.java View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_analysis_server.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jwren
5 years, 11 months ago (2015-01-12 21:33:40 UTC) #2
Paul Berry
Re-execution of generator script lgtm. I don't feel qualified to review the isSocketOpen stuff.
5 years, 11 months ago (2015-01-12 21:39:31 UTC) #4
scheglov
LGTM
5 years, 11 months ago (2015-01-12 21:41:16 UTC) #5
jwren
5 years, 11 months ago (2015-01-12 21:47:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698