Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java

Issue 845973006: Addition of AnalysisServer.isSocketOpen for clients to know if the server is still running. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
diff --git a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
index e8b4c363104df016c62ea23c4c01641c7225a67b..89cb524f8f70200a1ea668e5d654eb63ad7d5aae 100644
--- a/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
+++ b/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java
@@ -72,19 +72,25 @@ public class AnalysisOptions {
private final Boolean generateDart2jsHints;
/**
- * True is hints should be generated as part of generating errors and warnings.
+ * True if hints should be generated as part of generating errors and warnings.
*/
private final Boolean generateHints;
/**
+ * True if lints should be generated as part of generating errors and warnings.
+ */
+ private final Boolean generateLints;
+
+ /**
* Constructor for {@link AnalysisOptions}.
*/
- public AnalysisOptions(Boolean enableAsync, Boolean enableDeferredLoading, Boolean enableEnums, Boolean generateDart2jsHints, Boolean generateHints) {
+ public AnalysisOptions(Boolean enableAsync, Boolean enableDeferredLoading, Boolean enableEnums, Boolean generateDart2jsHints, Boolean generateHints, Boolean generateLints) {
this.enableAsync = enableAsync;
this.enableDeferredLoading = enableDeferredLoading;
this.enableEnums = enableEnums;
this.generateDart2jsHints = generateDart2jsHints;
this.generateHints = generateHints;
+ this.generateLints = generateLints;
}
@Override
@@ -96,7 +102,8 @@ public class AnalysisOptions {
ObjectUtilities.equals(other.enableDeferredLoading, enableDeferredLoading) &&
ObjectUtilities.equals(other.enableEnums, enableEnums) &&
ObjectUtilities.equals(other.generateDart2jsHints, generateDart2jsHints) &&
- ObjectUtilities.equals(other.generateHints, generateHints);
+ ObjectUtilities.equals(other.generateHints, generateHints) &&
+ ObjectUtilities.equals(other.generateLints, generateLints);
}
return false;
}
@@ -107,7 +114,8 @@ public class AnalysisOptions {
Boolean enableEnums = jsonObject.get("enableEnums") == null ? null : jsonObject.get("enableEnums").getAsBoolean();
Boolean generateDart2jsHints = jsonObject.get("generateDart2jsHints") == null ? null : jsonObject.get("generateDart2jsHints").getAsBoolean();
Boolean generateHints = jsonObject.get("generateHints") == null ? null : jsonObject.get("generateHints").getAsBoolean();
- return new AnalysisOptions(enableAsync, enableDeferredLoading, enableEnums, generateDart2jsHints, generateHints);
+ Boolean generateLints = jsonObject.get("generateLints") == null ? null : jsonObject.get("generateLints").getAsBoolean();
+ return new AnalysisOptions(enableAsync, enableDeferredLoading, enableEnums, generateDart2jsHints, generateHints, generateLints);
}
public static List<AnalysisOptions> fromJsonArray(JsonArray jsonArray) {
@@ -158,12 +166,19 @@ public class AnalysisOptions {
}
/**
- * True is hints should be generated as part of generating errors and warnings.
+ * True if hints should be generated as part of generating errors and warnings.
*/
public Boolean getGenerateHints() {
return generateHints;
}
+ /**
+ * True if lints should be generated as part of generating errors and warnings.
+ */
+ public Boolean getGenerateLints() {
+ return generateLints;
+ }
+
@Override
public int hashCode() {
HashCodeBuilder builder = new HashCodeBuilder();
@@ -172,6 +187,7 @@ public class AnalysisOptions {
builder.append(enableEnums);
builder.append(generateDart2jsHints);
builder.append(generateHints);
+ builder.append(generateLints);
return builder.toHashCode();
}
@@ -192,6 +208,9 @@ public class AnalysisOptions {
if (generateHints != null) {
jsonObject.addProperty("generateHints", generateHints);
}
+ if (generateLints != null) {
+ jsonObject.addProperty("generateLints", generateLints);
+ }
return jsonObject;
}
@@ -208,7 +227,9 @@ public class AnalysisOptions {
builder.append("generateDart2jsHints=");
builder.append(generateDart2jsHints + ", ");
builder.append("generateHints=");
- builder.append(generateHints);
+ builder.append(generateHints + ", ");
+ builder.append("generateLints=");
+ builder.append(generateLints);
builder.append("]");
return builder.toString();
}

Powered by Google App Engine
This is Rietveld 408576698