Issue 842263002: Really really fix mac x64 debug build by using more fixed-length encoding and long jumps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 842263002: Really really fix mac x64 debug build by using more fixed-length encoding and long jumps. (Closed)

Created:
5 years, 11 months ago by koda

Modified:
5 years, 11 months ago

Reviewers:
Florian Schneider, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Really really fix mac x64 debug build by using more fixed-length encoding and long jumps. (We could consider always using fixed-length encoding in DEBUG mode to avoid this.) R=iposva@google.com TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42753

Patch Set 1 #

Total comments: 2

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	runtime/vm/assembler_x64.cc	View		2 chunks	+4 lines, -2 lines	2 comments	Download
	M	runtime/vm/stub_code_x64.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

Committed patchset #1 (id:1) manually as r42753 (presubmit successful).

5 years, 11 months ago (2015-01-09 20:34:03 UTC) #3

Florian Schneider

5 years, 11 months ago (2015-01-12 10:31:51 UTC) #5

Message was sent while issue was closed.

style dbc:

https://codereview.chromium.org/842263002/diff/1/runtime/vm/assembler_x64.cc
File runtime/vm/assembler_x64.cc (right):

https://codereview.chromium.org/842263002/diff/1/runtime/vm/assembler_x64.cc#...
runtime/vm/assembler_x64.cc:3062: static const bool kFixedLengthEncoding = true;
It does not matter here, but I think we tend not to use static linkage for local
variables. There isn't any benefit here either, so I'd just drop static for this
local.

https://codereview.chromium.org/842263002/diff/1/runtime/vm/assembler_x64.cc#...
runtime/vm/assembler_x64.cc:3081: static const bool kFixedLengthEncoding = true;
Same.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages