Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 841303002: Non fatal errors on duplicated accessors (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/non_fatal_modelx
Visibility:
Public.

Description

Non fatal errors on duplicated accessors. BUG=https://code.google.com/p/dart/issues/detail?id=22019 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42767

Patch Set 1 : #

Patch Set 2 : Merged with r42766. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -9 lines) Patch
M dart/pkg/compiler/lib/src/elements/modelx.dart View 6 chunks +29 lines, -8 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/class_members.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/warnings.dart View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
Without the changes to class_members.dart, you get additional confusing errors about invalid overrides: tests/co19/src/Language/07_Classes/07_Classes_A07_t02.dart:17:11: Error: ...
5 years, 11 months ago (2015-01-09 13:56:26 UTC) #3
Johnni Winther
lgtm
5 years, 11 months ago (2015-01-09 14:35:22 UTC) #4
ahe
5 years, 11 months ago (2015-01-12 10:15:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 42767 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698