Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2276)

Unified Diff: dart/pkg/compiler/lib/src/resolution/class_members.dart

Issue 841303002: Non fatal errors on duplicated accessors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Merged with r42766. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/pkg/compiler/lib/src/elements/modelx.dart ('k') | dart/pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/compiler/lib/src/resolution/class_members.dart
diff --git a/dart/pkg/compiler/lib/src/resolution/class_members.dart b/dart/pkg/compiler/lib/src/resolution/class_members.dart
index 5e753f8c812b4219625d94d5199b184da27c701c..7fd7edc321700678abd130ec76a726c0452d82f9 100644
--- a/dart/pkg/compiler/lib/src/resolution/class_members.dart
+++ b/dart/pkg/compiler/lib/src/resolution/class_members.dart
@@ -348,8 +348,15 @@ abstract class MembersCreator {
}
} else {
assert(declared.name == superMember.name);
+
if (declared.isStatic) {
for (Member inherited in superMember.declarations) {
+ if (cls == inherited.declarer.element) {
+ // An error should already have been reported.
+ assert(invariant(declared.element, compiler.compilationFailed));
+ continue;
+ }
+
reportMessage(
inherited.element, MessageKind.NO_STATIC_OVERRIDE, () {
reportErrorWithContext(
@@ -361,6 +368,11 @@ abstract class MembersCreator {
DartType declaredType = declared.functionType;
for (Member inherited in superMember.declarations) {
+ if (cls == inherited.declarer.element) {
+ // An error should already have been reported.
+ assert(invariant(declared.element, compiler.compilationFailed));
+ continue;
+ }
void reportError(MessageKind errorKind, MessageKind infoKind) {
reportMessage(
« no previous file with comments | « dart/pkg/compiler/lib/src/elements/modelx.dart ('k') | dart/pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698