Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 840473007: Minor clean-ups and rename (Closed)

Created:
5 years, 11 months ago by Brian Wilkerson
Modified:
5 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M pkg/analysis_server/lib/plugin/plugin.dart View 2 chunks +10 lines, -10 lines 2 comments Download
M pkg/analysis_server/lib/src/plugin/plugin_impl.dart View 5 chunks +14 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 11 months ago (2015-01-12 16:14:00 UTC) #2
scheglov
LGTM https://codereview.chromium.org/840473007/diff/1/pkg/analysis_server/lib/plugin/plugin.dart File pkg/analysis_server/lib/plugin/plugin.dart (right): https://codereview.chromium.org/840473007/diff/1/pkg/analysis_server/lib/plugin/plugin.dart#newcode27 pkg/analysis_server/lib/plugin/plugin.dart:27: [ValidateExtension validator]); Just a question: Should this parameter ...
5 years, 11 months ago (2015-01-12 16:17:50 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/840473007/diff/1/pkg/analysis_server/lib/plugin/plugin.dart File pkg/analysis_server/lib/plugin/plugin.dart (right): https://codereview.chromium.org/840473007/diff/1/pkg/analysis_server/lib/plugin/plugin.dart#newcode27 pkg/analysis_server/lib/plugin/plugin.dart:27: [ValidateExtension validator]); Good catch. Done.
5 years, 11 months ago (2015-01-12 16:35:03 UTC) #4
Brian Wilkerson
5 years, 11 months ago (2015-01-12 16:36:58 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 42776 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698