Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 839833003: Speedup profile generation for stress test benchmark by 176x (Closed)

Created:
5 years, 11 months ago by Cutch
Modified:
5 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Speedup profile generation for stress test benchmark by 176x Processed 779753 frames CodeTables: live=9604 dead=5345 tag=51 FixTopFrame took 158092 millis. CodeRegionTableBuilder took 13616 millis. CodeRegionExclusiveTrieBuilder took 283 millis. CodeRegionTableCallersBuilder took 57 millis. CodeTableStream took 5637 millis. ~176 seconds --- Fix PageSpace::FindObject to fast path executable pages Processed 648584 frames CodeTables: live=9398 dead=4655 tag=45 FixTopFrame took 68401 millis. CodeRegionTableBuilder took 6401 millis. CodeRegionExclusiveTrieBuilder took 222 millis. CodeRegionTableCallersBuilder took 45 millis. CodeTableStream took 267 millis. ~74 seconds --- Fix PageSpace::Contains to fast path executable pages Processed 690756 frames CodeTables: live=9329 dead=5310 tag=49 FixTopFrame took 234 millis. CodeRegionTableBuilder took 173 millis. CodeRegionExclusiveTrieBuilder took 265 millis. CodeRegionTableCallersBuilder took 60 millis. CodeTableStream took 331 millis. ~1 second R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=42672

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -5 lines) Patch
M runtime/vm/pages.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/pages.cc View 1 2 4 chunks +81 lines, -1 line 0 comments Download
M runtime/vm/profiler.cc View 6 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 11 months ago (2015-01-07 20:52:43 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/839833003/diff/20001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/839833003/diff/20001/runtime/vm/pages.cc#newcode446 runtime/vm/pages.cc:446: // Provides exclusive access to code pages, ...
5 years, 11 months ago (2015-01-07 21:35:04 UTC) #3
Cutch
https://codereview.chromium.org/839833003/diff/20001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/839833003/diff/20001/runtime/vm/pages.cc#newcode446 runtime/vm/pages.cc:446: // Provides exclusive access to code pages, and ensures ...
5 years, 11 months ago (2015-01-07 21:38:03 UTC) #4
Cutch
5 years, 11 months ago (2015-01-07 21:39:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698