Speedup profile generation for stress test benchmark by 176x

runtime/vm/profiler.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/address_sanitizer.h"
 #include "platform/memory_sanitizer.h"
 #include "platform/utils.h"
 
 #include "vm/allocation.h"
 #include "vm/atomic.h"
@@ skipping 12 matching lines @@
 
 namespace dart {
 
 
 #if defined(TARGET_OS_ANDROID) || defined(HOST_ARCH_ARM64)
   DEFINE_FLAG(bool, profile, false, "Enable Sampling Profiler");
 #else
   DEFINE_FLAG(bool, profile, true, "Enable Sampling Profiler");
 #endif
 DEFINE_FLAG(bool, trace_profiled_isolates, false, "Trace profiled isolates.");
+DEFINE_FLAG(bool, trace_profiler, false, "Trace profiler.");
 DEFINE_FLAG(charp, profile_dir, NULL,
             "Enable writing profile data into specified directory.");
 DEFINE_FLAG(int, profile_period, 1000,
             "Time between profiler samples in microseconds. Minimum 50.");
 DEFINE_FLAG(int, profile_depth, 8,
             "Maximum number stack frames walked. Minimum 1. Maximum 255.");
 #if defined(PROFILE_NATIVE_CODE) || defined(USING_SIMULATOR)
 DEFINE_FLAG(bool, profile_vm, true,
             "Always collect native stack traces.");
 #else
@@ skipping 127 matching lines @@
     return;
   }
   ASSERT(initialized_);
   ThreadInterrupter::Unregister();
 }
 
 
 class ScopeStopwatch : public ValueObject {
  public:
   explicit ScopeStopwatch(const char* name) : name_(name) {
-    start_ = FLAG_trace_profiled_isolates ? OS::GetCurrentTimeMillis() : 0;
+    start_ = FLAG_trace_profiler ? OS::GetCurrentTimeMillis() : 0;
   }
 
   int64_t GetElapsed() const {
     int64_t end = OS::GetCurrentTimeMillis();
     ASSERT(end >= start_);
     return end - start_;
   }
 
   ~ScopeStopwatch() {
-    if (FLAG_trace_profiled_isolates) {
+    if (FLAG_trace_profiler) {
       int64_t elapsed = GetElapsed();
       OS::Print("%s took %" Pd64 " millis.\n", name_, elapsed);
     }
   }
 
  private:
   const char* name_;
   int64_t start_;
 };
 
@@ skipping 1242 matching lines @@
       CodeRegionTable live_code_table;
       // Dead code holds Overwritten CodeRegions.
       CodeRegionTable dead_code_table;
       // Tag code holds Tag CodeRegions.
       CodeRegionTable tag_code_table;
       CodeRegionTableBuilder builder(isolate,
                                      &live_code_table,
                                      &dead_code_table,
                                      &tag_code_table);
       {
+        ScopeStopwatch sw("FixTopFrame");
         // Preprocess samples and fix the caller when the top PC is in a
         // stub or intrinsic without a frame.
         FixTopFrameVisitor fixTopFrame(isolate);
         sample_buffer->VisitSamples(&fixTopFrame);
       }
       {
         // Build CodeRegion tables.
         ScopeStopwatch sw("CodeRegionTableBuilder");
         sample_buffer->VisitSamples(&builder);
       }
       intptr_t samples = builder.visited();
       intptr_t frames = builder.frames();
-      if (FLAG_trace_profiled_isolates) {
+      if (FLAG_trace_profiler) {
         intptr_t total_live_code_objects = live_code_table.Length();
         intptr_t total_dead_code_objects = dead_code_table.Length();
         intptr_t total_tag_code_objects = tag_code_table.Length();
         OS::Print("Processed %" Pd " frames\n", frames);
         OS::Print("CodeTables: live=%" Pd " dead=%" Pd " tag=%" Pd "\n",
                   total_live_code_objects,
                   total_dead_code_objects,
                   total_tag_code_objects);
       }
 #if defined(DEBUG)
       live_code_table.Verify();
       dead_code_table.Verify();
       tag_code_table.Verify();
-      if (FLAG_trace_profiled_isolates) {
+      if (FLAG_trace_profiler) {
         OS::Print("CodeRegionTables verified to be ordered and not overlap.\n");
       }
 #endif
       CodeRegionExclusiveTrieBuilder build_trie(isolate,
                                                 &live_code_table,
                                                 &dead_code_table,
                                                 &tag_code_table);
       build_trie.set_tag_order(tag_order);
       {
         // Build CodeRegion trie.
@@ skipping 633 matching lines @@
                                             state.pc,
                                             state.fp,
                                             sp);
       stackWalker.walk();
 #endif
     }
   }
 }
 
 }  // namespace dart