Issue 83963003: Removes EPOLLONESHOT from Android eventhandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83963003: Removes EPOLLONESHOT from Android eventhandler. (Closed)

Created:
7 years ago by zra

Modified:
7 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen, Søren Gjesse

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Removes EPOLLONESHOT from Android eventhandler. It doesn't exist in the NDK. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30598

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	runtime/bin/eventhandler_android.cc	View	1 2	3 chunks	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

zra

This backs-out the Android change from: https://codereview.chromium.org/82873002/ which was breaking the Android standalone VM build.

7 years ago (2013-11-22 22:36:54 UTC) #1

Ivan Posva

Don't you also have to revert https://codereview.chromium.org/83483003/diff/1/runtime/bin/eventhandler_android.cc ? -Ivan

7 years ago (2013-11-22 22:40:52 UTC) #2

zra

Reverted this file back to r30565 before it looks like these changes started.

7 years ago (2013-11-22 23:01:49 UTC) #3

Ivan Posva

LGTM -ip https://codereview.chromium.org/83963003/diff/60001/runtime/bin/eventhandler_android.cc File runtime/bin/eventhandler_android.cc (right): https://codereview.chromium.org/83963003/diff/60001/runtime/bin/eventhandler_android.cc#newcode179 runtime/bin/eventhandler_android.cc:179: InterruptMessage msg; As discussed I don't think ...

7 years ago (2013-11-22 23:38:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r30598 (presubmit successful).

Expand Messages | Collapse Messages

Issue 83963003: Removes EPOLLONESHOT from Android eventhandler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages