Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 839463003: Remove redundant set of ResolvableLibrary.libraryElement. (Closed)

Created:
5 years, 11 months ago by Paul Berry
Modified:
5 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Remove redundant set of ResolvableLibrary.libraryElement. LibraryElementBuilder.buildLibrary2() always sets it, so there's no reason for the caller to set it as well. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=42798

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 11 months ago (2015-01-12 23:40:52 UTC) #2
Brian Wilkerson
LGTM
5 years, 11 months ago (2015-01-13 00:21:18 UTC) #3
Paul Berry
5 years, 11 months ago (2015-01-13 03:08:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42798 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698