Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1022)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 838053003: suggest fields rather than synthetic getters (Closed)

Created:
5 years, 11 months ago by danrubel
Modified:
5 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

suggest fields rather than synthetic getters BUG=dartbug.com/21679 R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42712

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 2 chunks +10 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 8 chunks +70 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_computer_test.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
5 years, 11 months ago (2015-01-08 02:18:29 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/838053003/diff/1/pkg/analysis_server/lib/src/services/completion/local_computer.dart File pkg/analysis_server/lib/src/services/completion/local_computer.dart (right): https://codereview.chromium.org/838053003/diff/1/pkg/analysis_server/lib/src/services/completion/local_computer.dart#newcode268 pkg/analysis_server/lib/src/services/completion/local_computer.dart:268: CompletionSuggestion _addSuggestion(SimpleIdentifier id, TypeName typeName, Consider renaming "typeName" ...
5 years, 11 months ago (2015-01-08 19:09:35 UTC) #3
danrubel
https://codereview.chromium.org/838053003/diff/1/pkg/analysis_server/lib/src/services/completion/local_computer.dart File pkg/analysis_server/lib/src/services/completion/local_computer.dart (right): https://codereview.chromium.org/838053003/diff/1/pkg/analysis_server/lib/src/services/completion/local_computer.dart#newcode268 pkg/analysis_server/lib/src/services/completion/local_computer.dart:268: CompletionSuggestion _addSuggestion(SimpleIdentifier id, TypeName typeName, On 2015/01/08 19:09:35, Paul ...
5 years, 11 months ago (2015-01-08 19:34:40 UTC) #4
danrubel
5 years, 11 months ago (2015-01-08 19:35:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 42712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698