Issue 834323006: Revert "Lint contribution refactoring.", r42967

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 834323006: Revert "Lint contribution refactoring.", r42967 (Closed)

Created:
5 years, 11 months ago by Bill Hesse

Modified:
5 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, pquitslund

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Revert "Lint contribution refactoring.", r42967 This reverts commit r42967, https://codereview.chromium.org//853123002. The change causes an out-of-memory crash in analyzer batch mode, perhaps a memory leak. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=42979

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -940 lines)			Patch
M	pkg/analyzer/lib/src/generated/engine.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	2 chunks	+51 lines, -0 lines	0 comments	Download
A +	pkg/analyzer/lib/src/generated/visitors.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	pkg/analyzer/lib/src/services/lint.dart	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	pkg/analyzer/lib/src/visitors.dart	View	1 chunk	+0 lines, -772 lines	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	9 chunks	+100 lines, -101 lines	0 comments	Download

Total messages: 5 (1 generated)

Bill Hesse

Seems to cause a memory leak in batch mode, which crashes the analyzer.

5 years, 11 months ago (2015-01-19 09:23:29 UTC) #2

Bill Hesse

On 2015/01/19 09:23:29, Bill Hesse wrote: > Seems to cause a memory leak in batch ...

5 years, 11 months ago (2015-01-19 09:24:22 UTC) #3

Bill Hesse

5 years, 11 months ago (2015-01-19 09:26:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42979 (presubmit successful).