Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 832363002: Remove Compiler.assembledCode. (Closed)

Created:
5 years, 11 months ago by Johnni Winther
Modified:
5 years, 11 months ago
Reviewers:
ahe, floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Patch Set 3 : Rebased #

Patch Set 4 : Fix utils + incremental. #

Patch Set 5 : Fix unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -288 lines) Patch
M pkg/compiler/lib/compiler.dart View 1 3 chunks +26 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 4 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 6 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/outputter.dart View 6 chunks +15 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 4 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 2 3 2 chunks +38 lines, -1 line 0 comments Download
M pkg/dart2js_incremental/lib/dart2js_incremental.dart View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M site/try/src/compiler_isolate.dart View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 2 chunks +7 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_backend_test.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_new_backend_test.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/end2end_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/test_helper.dart View 1 chunk +5 lines, -2 lines 0 comments Download
D tests/compiler/dart2js/compiler_alt.dart View 1 chunk +0 lines, -48 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 7 chunks +27 lines, -23 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 3 chunks +14 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/incremental/hello_test.dart View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 3 chunks +3 lines, -36 lines 0 comments Download
M tests/compiler/dart2js/mirror_helper_rename_test.dart View 4 chunks +13 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +4 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/output_collector.dart View 1 chunk +44 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/source_map_d2js_validity_test.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/source_map_deferred_d2js_validity_test.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/uri_retention_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M tests/try/web/web_compiler_test_case.dart View 1 2 3 2 chunks +1 line, -39 lines 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M tests/utils/recursive_import_test.dart View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Johnni Winther
5 years, 11 months ago (2015-01-05 10:15:09 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/832363002/diff/1/pkg/compiler/lib/compiler.dart File pkg/compiler/lib/compiler.dart (right): https://codereview.chromium.org/832363002/diff/1/pkg/compiler/lib/compiler.dart#newcode70 pkg/compiler/lib/compiler.dart:70: /// `true` if the compilation succeeded. Specify that ...
5 years, 11 months ago (2015-01-05 10:39:33 UTC) #3
Johnni Winther
https://codereview.chromium.org/832363002/diff/1/pkg/compiler/lib/compiler.dart File pkg/compiler/lib/compiler.dart (right): https://codereview.chromium.org/832363002/diff/1/pkg/compiler/lib/compiler.dart#newcode70 pkg/compiler/lib/compiler.dart:70: /// `true` if the compilation succeeded. On 2015/01/05 10:39:33, ...
5 years, 11 months ago (2015-01-05 13:54:10 UTC) #4
Johnni Winther
Committed patchset #2 (id:20001) manually as 42592 (presubmit successful).
5 years, 11 months ago (2015-01-05 14:08:06 UTC) #5
Johnni Winther
PTAL at the last patch set
5 years, 11 months ago (2015-01-06 10:16:09 UTC) #8
floitsch
LGTM.
5 years, 11 months ago (2015-01-06 10:23:03 UTC) #9
Johnni Winther
Committed patchset #5 (id:90001) manually as 42623 (presubmit successful).
5 years, 11 months ago (2015-01-06 11:07:44 UTC) #10
ahe
5 years, 11 months ago (2015-01-07 13:29:35 UTC) #11
Message was sent while issue was closed. 
Changes to tests/try, pkg/dart2js_incremental, and site/try: LGTM!

Appreciate that you moved the code from the test instead of copying it!

Powered by Google App Engine
This is Rietveld 408576698