Remove Compiler.assembledCode.

pkg/compiler/lib/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library compiler;
 
 import 'dart:async';
 import 'src/apiimpl.dart';
 
 // Unless explicitly allowed, passing [:null:] for any argument to the
@@ skipping 47 matching lines @@
  * [:null:]. If [uri] is not [:null:], neither are [begin] and
  * [end]. [uri] indicates the compilation unit from where the
  * diagnostic originates. [begin] and [end] are zero-based character
  * offsets from the beginning of the compilaton unit. [message] is the
  * diagnostic message, and [kind] indicates indicates what kind of
  * diagnostic it is.
  */
 typedef void DiagnosticHandler(Uri uri, int begin, int end,
                                String message, Diagnostic kind);
 
+/// Information resulting from the compilation.
+class CompilationResult {
+  /// `true` if the compilation succeeded.

[floitsch, 2015/01/05 10:39:33]

Specify that "succeeded" means "valid program" and not just that the compiler
didn't crash.

[Johnni Winther, 2015/01/05 13:54:10]

Done.

+  final bool isSuccess;
+
+  /// The compiler object used for the compilation.
+  ///
+  /// Note: The type of [compiler] is implementation dependent and may vary.
+  /// Use only for debugging and testing.
+  final compiler;
+
+  /// The compilation resulted in this exception.
+  final exception;
+
+  /// The compilation resulted in an exception with this stack trace.
+  final trace;
+
+  CompilationResult(this.compiler, {this.isSuccess: true})
+      : exception = null, trace = null;
+
+  CompilationResult.error(this.exception, this.trace)
+      : compiler = null, isSuccess = false;
+}
+
 /**
  * Returns a future that completes to a non-null String when [script]
  * has been successfully compiled.
  *
  * The compiler output is obtained by providing an [outputProvider].
  *
  * If the compilation fails, the future's value will be [:null:] and
  * [handler] will have been invoked at least once with [:kind ==
  * Diagnostic.ERROR:] or [:kind == Diagnostic.CRASH:].
  *
  * Deprecated: if no [outputProvider] is given, the future completes
  * to the compiled script. This behavior will be removed in the future
  * as the compiler may create multiple files to support lazy loading
  * of libraries.
  */
-Future<String> compile(Uri script,
-                       Uri libraryRoot,
-                       Uri packageRoot,
-                       CompilerInputProvider inputProvider,
-                       DiagnosticHandler handler,
-                       [List<String> options = const [],
-                        CompilerOutputProvider outputProvider,
-                        Map<String, dynamic> environment = const {}]) {
+Future<CompilationResult> compile(
+    Uri script,
+    Uri libraryRoot,
+    Uri packageRoot,
+    CompilerInputProvider inputProvider,
+    DiagnosticHandler handler,
+    [List<String> options = const [],
+     CompilerOutputProvider outputProvider,
+     Map<String, dynamic> environment = const {}]) {
   if (!libraryRoot.path.endsWith("/")) {
     throw new ArgumentError("libraryRoot must end with a /");
   }
   if (packageRoot != null && !packageRoot.path.endsWith("/")) {
     throw new ArgumentError("packageRoot must end with a /");
   }
   // TODO(ahe): Consider completing the future with an exception if
   // code is null.
   Compiler compiler = new Compiler(inputProvider,
                                    outputProvider,
                                    handler,
                                    libraryRoot,
                                    packageRoot,
                                    options,
                                    environment);
-  // TODO(ahe): Use the value of the future (which signals success or failure).
-  return compiler.run(script).then((_) {
-    String code = compiler.assembledCode;
-    if (code != null && outputProvider != null) {
-      code = ''; // Non-null signals success.
-    }
-    return code;
+  return compiler.run(script).then((bool success) {
+    return new CompilationResult(compiler, isSuccess: success);
   });
 }
 
 /**
  * Kind of diagnostics that the compiler can report.
  */
 class Diagnostic {
   /**
    * An error as identified by the "Dart Programming Language
    * Specification" [http://www.dartlang.org/docs/spec/].
@@ skipping 55 matching lines @@
   final String name;
 
   /**
    * This constructor is not private to support user-defined
    * diagnostic kinds.
    */
   const Diagnostic(this.ordinal, this.name);
 
   String toString() => name;
 }