Issue 832143007: Issue 22044. A changes in annotations should be considered as a mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 832143007: Issue 22044. A changes in annotations should be considered as a mismatch. (Closed)

Created:
5 years, 11 months ago by scheglov

Modified:
5 years, 11 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Issue 22044. A changes in annotations should be considered as a mismatch. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=22044 Committed: https://code.google.com/p/dart/source/detail?r=42783

Patch Set 2 : Positive tests. #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -1 line)			Patch
	M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		5 chunks	+24 lines, -1 line	0 comments	Download
	M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	1	4 chunks	+120 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/832143007/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart File pkg/analyzer/test/generated/incremental_resolver_test.dart (right): https://codereview.chromium.org/832143007/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart#newcode73 pkg/analyzer/test/generated/incremental_resolver_test.dart:73: void test_false_class_annotation_edit() { Might be good to add ...

5 years, 11 months ago (2015-01-12 17:46:57 UTC) #2

scheglov

5 years, 11 months ago (2015-01-12 17:53:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42783 (presubmit successful).

Expand Messages | Collapse Messages

Issue 832143007: Issue 22044. A changes in annotations should be considered as a mismatch. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Positive tests. #

Messages