Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: pkg/analyzer/test/generated/incremental_resolver_test.dart

Issue 832143007: Issue 22044. A changes in annotations should be considered as a mismatch. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Positive tests. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/incremental_resolver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/incremental_resolver_test.dart
diff --git a/pkg/analyzer/test/generated/incremental_resolver_test.dart b/pkg/analyzer/test/generated/incremental_resolver_test.dart
index 9522bf472a7456d7624952e2414aeb9877381fb9..6f3f8484fd4604b7c86a2574f46539d19ba692a7 100644
--- a/pkg/analyzer/test/generated/incremental_resolver_test.dart
+++ b/pkg/analyzer/test/generated/incremental_resolver_test.dart
@@ -70,6 +70,48 @@ class DeclarationMatcherTest extends ResolverTestCase {
test_resolveApiChanges = true;
}
+ void test_false_class_annotation_edit() {
+ _assertDoesNotMatch(r'''
+const my_annotationA = const Object();
+const my_annotationB = const Object();
+@my_annotationA
+class A {
+}
+''', r'''
+const my_annotationA = const Object();
+const my_annotationB = const Object();
+@my_annotationB
+class A {
+}
+''');
+ }
+
+ void test_false_class_annotations_add() {
+ _assertDoesNotMatch(r'''
+const my_annotation = const Object();
+class A {
+}
+''', r'''
+const my_annotation = const Object();
+@my_annotation
+class A {
+}
+''');
+ }
+
+ void test_false_class_annotations_remove() {
+ _assertDoesNotMatch(r'''
+const my_annotation = const Object();
+@my_annotation
+class A {
+}
+''', r'''
+const my_annotation = const Object();
+class A {
+}
+''');
+ }
+
void test_false_class_list_add() {
_assertDoesNotMatch(r'''
class A {}
@@ -811,6 +853,54 @@ import 'dart:async' show Future;
''');
}
+ void test_false_method_annotation_edit() {
+ _assertDoesNotMatchOK(r'''
+const my_annotationA = const Object();
+const my_annotationB = const Object();
+class A {
+ @my_annotationA
+ void m() {}
+}
+''', r'''
+const my_annotationA = const Object();
+const my_annotationB = const Object();
+class A {
+ @my_annotationB
+ void m() {}
+}
+''');
+ }
+
+ void test_false_method_annotations_add() {
+ _assertDoesNotMatchOK(r'''
+const my_annotation = const Object();
+class A {
+ void m() {}
+}
+''', r'''
+const my_annotation = const Object();
+class A {
+ @my_annotation
+ void m() {}
+}
+''');
+ }
+
+ void test_false_method_annotations_remove() {
+ _assertDoesNotMatchOK(r'''
+const my_annotation = const Object();
+class A {
+ @my_annotation
+ void m() {}
+}
+''', r'''
+const my_annotation = const Object();
+class A {
+ void m() {}
+}
+''');
+ }
+
void test_false_method_list_add() {
_assertDoesNotMatchOK(r'''
class A {
@@ -1183,6 +1273,20 @@ class C extends Object with B, A {}
''');
}
+ void test_true_class_annotations_same() {
+ _assertMatches(r'''
+const my_annotation = const Object();
+@my_annotation
+class A {
+}
+''', r'''
+const my_annotation = const Object();
+@my_annotation
+class A {
+}
+''');
+ }
+
void test_true_class_list_reorder() {
_assertMatches(r'''
class A {}
@@ -1611,6 +1715,22 @@ import 'dart:async' show Stream, Future;
''');
}
+ void test_true_method_annotations_same() {
+ _assertMatches(r'''
+const my_annotation = const Object();
+class A {
+ @my_annotation
+ void m() {}
+}
+''', r'''
+const my_annotation = const Object();
+class A {
+ @my_annotation
+ void m() {}
+}
+''');
+ }
+
void test_true_method_list_reorder() {
_assertMatches(r'''
class A {
« no previous file with comments | « pkg/analyzer/lib/src/generated/incremental_resolver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698