Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 831213002: Omit variables beginning with "=" from Windows environment. (Closed)

Created:
5 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Omit variables beginning with "=" from Windows environment. BUG= http://dartbug.com/21961 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=42591

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update documentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M runtime/bin/platform_win.cc View 1 1 chunk +8 lines, -3 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 2 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lasse Reichstein Nielsen
5 years, 11 months ago (2015-01-05 11:51:14 UTC) #2
Søren Gjesse
lgtm Maybe parts of the comment in the commit just made (https://code.google.com/p/dart/source/detail?r=42589) should be shaved ...
5 years, 11 months ago (2015-01-05 12:39:30 UTC) #3
Søren Gjesse
lgtm - much easier to understand!
5 years, 11 months ago (2015-01-05 13:08:06 UTC) #4
Lasse Reichstein Nielsen
Committed patchset #2 (id:20001) manually as 42591 (presubmit successful).
5 years, 11 months ago (2015-01-05 13:08:48 UTC) #5
Lasse Reichstein Nielsen
5 years, 11 months ago (2015-01-05 13:09:24 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/831213002/diff/1/runtime/bin/platform_win.cc
File runtime/bin/platform_win.cc (right):

https://codereview.chromium.org/831213002/diff/1/runtime/bin/platform_win.cc#...
runtime/bin/platform_win.cc:46: while (*tmp != '\0') {
On 2015/01/05 12:39:30, Søren Gjesse wrote:
> Please add a comment why these are skipped.

Done.

Powered by Google App Engine
This is Rietveld 408576698