Omit variables beginning with "=" from Windows environment.

sdk/lib/io/platform_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 class _Platform {
   external static int _numberOfProcessors();
   external static String _pathSeparator();
   external static String _operatingSystem();
   external static _localHostname();
   external static _executable();
+  /**
+   * Retrieve the entries of the process environment.
+   *
+   * The result is an [Iterable] of strings, where each string represents
+   * an environment entry.
+   *
+   * Environment entries should be strings containing
+   * a non-empty name and a value separated by a '=' character.
+   * The name does not contain a '=' character,
+   * so the name is everything up to the first '=' character.
+   * Values are everything after the first '=' charcacter.
+   * A value may contain further '=' characters, and it may be empty.
+   *
+   * Returns an [OSError] if retrieving the environment fails.
+   */
   external static _environment();
   external static List<String> _executableArguments();
   external static String _packageRoot();
   external static String _version();
 
   static String executable = _executable();
   static String packageRoot = _packageRoot();
 
   // Cache the OS environemnt. This can be an OSError instance if
   // retrieving the environment failed.
@@ skipping 28 matching lines @@
 
   static List<String> get executableArguments => _executableArguments();
 
   static Map<String, String> get environment {
     if (_environmentCache == null) {
       var env = _environment();
       if (env is !OSError) {
         var isWindows = operatingSystem == 'windows';
         var result = isWindows ? new _CaseInsensitiveStringMap() : new Map();
         for (var str in env) {
-          // When running on Windows through cmd.exe there are
-          // entries which starts with '='. In CMD scripting,
-          // variables are "dynamic" environment variables which change
-          // automatically. The values of the ones starting with "=" are
-          // reified in the environment string of a new program (but, e.g.,
-          // __CD__ isn't).
-          //
-          // One example are the use of the environment to communicate the
-          // current working directory for each drive and the exit code for the
-          // last command. E.g. the entry '=A:=A:\subdir' records the current
-          // working directory on the 'A' drive.
-          //
-          // On Mac OS an entry of just '=' has been seen.
-          //
-          // Entries starting with '=' are ignored.
-          //
-          // Entries with no '=' should not happen. If it should happen,
-          // the entry is ignored.
+          // The Strings returned by [_environment()] are expected to be
+          // valid environment entries, but exceptions have been seen
+          // (e.g., an entry of just '=' has been seen on OS/X).
+          // Invalid entries (lines without a '=' or with an empty name)
+          // are discarded.
           var equalsIndex = str.indexOf('=');
           if (equalsIndex > 0) {
             result[str.substring(0, equalsIndex)] =
                 str.substring(equalsIndex + 1);
           }
         }
         _environmentCache = new UnmodifiableMapView<String, String>(result);
       } else {
         _environmentCache = env;
       }
@@ skipping 29 matching lines @@
   V remove(String key) => _map.remove(key.toUpperCase());
   void clear() => _map.clear();
   void forEach(void f(String key, V value)) => _map.forEach(f);
   Iterable<String> get keys => _map.keys;
   Iterable<V> get values => _map.values;
   int get length => _map.length;
   bool get isEmpty => _map.isEmpty;
   bool get isNotEmpty => _map.isNotEmpty;
   String toString() => _map.toString();
 }