Inline the fixed array constructor manually in the SSA builder. Also track whether a fixed array ev…

Inline the fixed array constructor manually in the SSA builder. Also track whether a fixed array ever flows into a method that may check if it is growable.

Also fixes new List(null): it now throws.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30612

[kasperl, 2013-11-25 08:16:44]

LGTM.

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart
(right):

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:144:
bool checksGrowable = false;
Is this always !enableLengthTracking? Should you update this flag when bailing
out?

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3897: js.Expression
code = js.js.parseForeignJS('new Array(#)');
You can get rid of new here.

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3903: code,
elementType, inputs, nativeBehavior: behavior, canThrow: true);
If you know something about the length (positive int) then maybe canThrow should
be false?

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3907: js.Expression
code = js.js.parseForeignJS('#.fixed\$length = init');
Use raw string instead of escaping $?

Since you have this code here now, does it still have to be in the JS helper
libraries?

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3909: // instruction
being dead code. We need a finer grain side
grain -> grained

[ngeoffray, 2013-11-25 08:33:31]

Thanks Kasper.

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart
(right):

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/inferrer/container_tracer.dart:144:
bool checksGrowable = false;
On 2013/11/25 08:16:44, kasperl wrote:
> Is this always !enableLengthTracking? Should you update this flag when bailing
> out?

Yes, it is always !enableLengthTracking. I combined both flags into a
'callsGrowableMethod' flag.

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3897: js.Expression
code = js.js.parseForeignJS('new Array(#)');
On 2013/11/25 08:16:44, kasperl wrote:
> You can get rid of new here.

Done.

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3903: code,
elementType, inputs, nativeBehavior: behavior, canThrow: true);
On 2013/11/25 08:16:44, kasperl wrote:
> If you know something about the length (positive int) then maybe canThrow
should
> be false?

Done.

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3907: js.Expression
code = js.js.parseForeignJS('#.fixed\$length = init');
On 2013/11/25 08:16:44, kasperl wrote:
> Use raw string instead of escaping $?

Done.

> 
> Since you have this code here now, does it still have to be in the JS helper
> libraries?

No, but if we go that route, I'd prefer making the List constructor be a no-op.
I plan on recognizing growable list implemenations here as well.

https://codereview.chromium.org/82953002/diff/20001/sdk/lib/_internal/compile...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3909: // instruction
being dead code. We need a finer grain side
On 2013/11/25 08:16:44, kasperl wrote:
> grain -> grained

Done.

[ngeoffray, 2013-11-25 09:11:06]

Committed patchset #2 manually as r30612 (presubmit successful).