Handle generic parameters correctly in invocation completions.

Handle generic parameters correctly in invocation completions.

When doing invocation completions, we need to walk the interface
types, not the classes, because the interface types record the actual
types of the generic parameters.  This required some rework because
the old technique used an element visitor, and interface types can't
be visited using an element visitor.

R=danrubel@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43040

[Paul Berry, 2015-01-15 00:22:51]

paulberry@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2015-01-15 02:53:25]

lgtm

https://codereview.chromium.org/829173003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/829173003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:260:
@override
Remove override annotation?

https://codereview.chromium.org/829173003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:330: if
(propertyAccessor.isGetter) {
A synthetic getter indicates an non-synthetic field, so why not visit
non-synthetic fields then non-synthetic getters/setters?

[Paul Berry, 2015-01-21 15:10:33]

https://codereview.chromium.org/829173003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart
(right):

https://codereview.chromium.org/829173003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:260:
@override
On 2015/01/15 02:53:25, danrubel wrote:
> Remove override annotation?

Done.

https://codereview.chromium.org/829173003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart:330: if
(propertyAccessor.isGetter) {
On 2015/01/15 02:53:25, danrubel wrote:
> A synthetic getter indicates an non-synthetic field, so why not visit
> non-synthetic fields then non-synthetic getters/setters?

That's true, but the only way InterfaceType provides to get access to the fields
is via ".accessors".  So there really isn't any other way to write this code.

[Paul Berry, 2015-01-21 15:16:58]

Committed patchset #1 (id:1) manually as 43040 (presubmit successful).