Handle generic parameters correctly in invocation completions.

pkg/analysis_server/lib/src/services/completion/invocation_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.invocation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/optype.dart';
@@ skipping 46 matching lines @@
   Future<bool> computeFull(AstNode node) {
     if (node is SimpleIdentifier) {
       node = node.parent;
     }
     if (node is MethodInvocation) {
       node = (node as MethodInvocation).realTarget;
     } else if (node is PropertyAccess) {
       node = (node as PropertyAccess).realTarget;
     }
     if (node is Expression) {
-      DartType type = node.bestType;
-      if (type != null) {
-        ClassElementSuggestionBuilder.suggestionsFor(request, type.element);
-        return new Future.value(true);
-      }
+      InterfaceTypeSuggestionBuilder.suggestionsFor(request, node.bestType);
+      return new Future.value(true);
     }
     return new Future.value(false);
   }
 }
 
 /**
  * An [AstNode] vistor for determining which suggestion builder
  * should be used to build invocation/access suggestions.
  */
 class _InvocationAstVisitor extends GeneralizingAstVisitor<SuggestionBuilder> {
@@ skipping 72 matching lines @@
       }
     }
     return new Future.value(false);
   }
 
   @override
   Future<bool> visitClassElement(ClassElement element) {
     if (element != null) {
       InterfaceType type = element.type;
       if (type != null) {
-        ClassElementSuggestionBuilder.suggestionsFor(
+        StaticClassElementSuggestionBuilder.suggestionsFor(
             request,
-            type.element,
-            staticOnly: true);
+            type.element);
       }
     }
     return new Future.value(false);
   }
 
   @override
   Future<bool> visitElement(Element element) {
     return new Future.value(false);
   }
 
@@ skipping 19 matching lines @@
       }
     });
     return new Future.value(modified);
   }
 
   @override
   Future<bool> visitPropertyAccessorElement(PropertyAccessorElement element) {
     if (element != null) {
       PropertyInducingElement elemVar = element.variable;
       if (elemVar != null) {
-        DartType type = elemVar.type;
-        if (type != null) {
-          ClassElementSuggestionBuilder.suggestionsFor(request, type.element);
-        }
+        InterfaceTypeSuggestionBuilder.suggestionsFor(request, elemVar.type);
       }
       return new Future.value(true);
     }
     return new Future.value(false);
   }
 
   @override
   Future<bool> visitVariableElement(VariableElement element) {
-    DartType type = element.type;
-    if (type != null) {
-      ClassElementSuggestionBuilder.suggestionsFor(request, type.element);
-    }
+    InterfaceTypeSuggestionBuilder.suggestionsFor(request, element.type);
     return new Future.value(true);
   }
 }